Separate PurchasesHybridCommonUI
#672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
added
pr:build
NachoSoto
force-pushed
the
split-revenuecat-ui
branch
from
fb59df4 to
ea8e9de
Compare
NachoSoto
changed the title
PurchasesHybridCommonUIPurchasesHybridCommonUI
NachoSoto
added
pr:breaking
NachoSoto
commented
Jan 22, 2024
PurchasesHybridCommon.podspec
Outdated
| @@ -17,7 +17,6 @@ Pod::Spec.new do |s| | |||
| s.framework = 'SwiftUI' | |||
|
|
|||
| s.dependency 'RevenueCat', '4.32.0' | |||
| s.dependency 'RevenueCatUI', '4.32.0' | |||
There was a problem hiding this comment.
This is the core performance improvement.
NachoSoto
added a commit
to RevenueCat/react-native-purchases
that referenced
this pull request
Jan 22, 2024
tonidero
approved these changes
Jan 22, 2024
NachoSoto
commented
Jan 23, 2024
tonidero
reviewed
Jan 23, 2024
|
|
||
| s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
|
|
||
| s.source_files = ['ios/PurchasesHybridCommon/PurchasesHybridCommonUI/**/*.{h,m,swift}'] |
There was a problem hiding this comment.
I do wonder if it would be better to separate into 2 separate folders inside the ios folder, so the separation is clearer... I'm ok with this though
There was a problem hiding this comment.
Good point, let me clean this
There was a problem hiding this comment.
Actually ios/PurchasesHybridCommon is where the Xcode project is, and since PurchasesHybridCommonUI is still part of the same project (just a different target), it makes sense that it's inside.
vegaro
reviewed
Jan 23, 2024
NachoSoto
force-pushed
the
split-revenuecat-ui
branch
from
84a9d98 to
a321df2
Compare
NachoSoto
force-pushed
the
split-revenuecat-ui
branch
from
49c2cf1 to
d23ea2b
Compare
NachoSoto
force-pushed
the
split-revenuecat-ui
branch
from
d23ea2b to
76a9eac
Compare
NachoSoto
added a commit
that referenced
this pull request
Jan 23, 2024
**This is an automatic release.** ### Breaking Changes * Separate `PurchasesHybridCommonUI` (#672) via NachoSoto (@NachoSoto) ### Other Changes * `CircleCI`: don't skip major bumps (#679) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
NachoSoto
added a commit
to RevenueCat/react-native-purchases
that referenced
this pull request
Jan 23, 2024
vegaro
pushed a commit
to RevenueCat/react-native-purchases
that referenced
this pull request
Jan 24, 2024
Depends on RevenueCat/purchases-hybrid-common#672 See also RevenueCat/purchases-flutter#943 --------- Co-authored-by: RevenueCat CI <dev+ci@revenuecat.com>
NachoSoto
added a commit
to RevenueCat/purchases-flutter
that referenced
this pull request
Jan 24, 2024
NachoSoto
added a commit
that referenced
this pull request
Feb 6, 2024
Fixes RevenueCat/purchases-flutter#963. This is likely there from before #672.
NachoSoto
added a commit
that referenced
this pull request
Feb 6, 2024
Fixes RevenueCat/purchases-flutter#963. This is likely there from before #672.
Merged
Jethro87
pushed a commit
to Jethro87/purchases-flutter
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For RevenueCat/purchases-flutter#939.