Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevenueCatUi.framework is 4 MB in my executable for iOS, and I do not even use it, wassup? #939

Closed
7 tasks done
mariopepe opened this issue Jan 18, 2024 · 7 comments · Fixed by #943
Closed
7 tasks done
Labels
bug Something isn't working pr:other triaged

Comments

@mariopepe
Copy link

Environment

  • Version of purchases-flutter: 6.16.0
  • Testing device version e.g.: iOS 15.5, Android API 30, etc.: iOS 17.0

Describe the bug

RevenueCat dependencies in my Flutter app compiled for iOS now takes 10 MB in total....
It's a bit much, considering we are not landing a rover on Mars, but just creating a layer with the AppStore...

In particular, I do not even use the RevenueCatUi, meaning I do the paywalls myself, how can I get rid of that 4 additional MBs?

Screenshot 2024-01-18 at 02 48 50
@mariopepe mariopepe added the bug Something isn't working label Jan 18, 2024
@RCGitBot
Copy link
Contributor

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@mariopepe
Copy link
Author

Revenuecat sdk, in the same app, compiled for Android is just 70 KB

Screenshot 2024-01-18 at 16 25 11

@michaelAtRC
Copy link

Hey @mariopepe !

Thanks for sharing, I have gone ahead and shared this with the SDK team. They are currently working on something that will help out with this and they will report back to the github issue with more information!

@NachoSoto
Copy link
Contributor

Thanks for letting us know! We split this dependency for Android but not for iOS. I'm currently working on that, so the next version of purchases-flutter won't include RevenueCatUI.

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Jan 22, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Jan 23, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Jan 23, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Jan 23, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Jan 23, 2024
@NachoSoto
Copy link
Contributor

Thanks again for filing this issue.
The change is ready (#943), and will be released shortly!

@NachoSoto
Copy link
Contributor

Thanks for your patience @mariopepe! The fix for this is now out on v6.17.0: RevenueCatUI is no longer included on purchases-flutter, only if using purchases-ui-fluter.

@mariopepe
Copy link
Author

Guys actually you were amazing, thanks so much and sorry if my comment was rude, i regret it! @NachoSoto @michaelAtRC

@vegaro vegaro added pr:other and removed pr:perf labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr:other triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants