Migrates Flutter to null safety #155

vegaro · 2021-02-23T01:10:07Z

I followed the steps in https://dart.dev/null-safety/migration-guide#step3-analyze and this PR is the result of the automatic migration.

We can publish this as version 3.0.0 of the SDK and it will show as a preview until dart 2.12.0 is out of beta.

Depends on #154

aboedo · 2021-02-23T14:18:23Z

it looks like the lint error will go away once this gets rebased from #154, so we should be good

aboedo

looking great! left a couple of questions

aboedo · 2021-02-23T14:34:04Z

lib/entitlement_info_wrapper.dart

@@ -38,13 +38,13 @@ class EntitlementInfo {
  /// The date an unsubscribe was detected. Can be `null`.
  /// @note: Entitlement may still be active even if user has unsubscribed.
  /// Check the `isActive` property.
-  final String unsubscribeDetectedAt;
+  final String? unsubscribeDetectedAt;

  /// The date a billing issue was detected. Can be `nil` if there is no


we should probably update the end of this line to "can be null if there is no"

aboedo · 2021-02-23T14:39:05Z

lib/entitlement_info_wrapper.dart

-    var periodType;
-    switch (json["periodType"] as String) {
+    late var periodType;
+    switch (json["periodType"] as String?) {


what does this switch do if periodType is null? do we need to add a case to handle it?

If periodType is null then no case will match and periodType will still NOT be initialized.

And when it‘s then passed to EntitlementInfo() constructor as it‘s expected to be non-null it will crash.

There are three options:

Leave it as it is and let it crash.

Add a case null: ... to handle the null case.

Make periodType nullable String? and be explicit that it may be null and handle it apprioriately.

I personally would prefer the last as it‘s the most transparent. So doing this:

String? periodType;

And then later:

EntitlementInfo( ..., periodType!, ... // Maybe this for the store (?!) store ?? Store.unknownStore, );

I think you are better suited to judge what consequences would be acceptable.
Completely, preventing any errors while parsing is probably never possible.

aboedo · 2021-02-23T14:39:22Z

lib/entitlement_info_wrapper.dart

-    var store;
-    switch (json["store"] as String) {
+    late var store;
+    switch (json["store"] as String?) {


same question regarding switching on null

aboedo · 2021-02-23T14:42:39Z

lib/purchases_flutter.dart

@@ -175,13 +175,13 @@ class Purchases {
  /// [upgradeInfo] Android only. Optional UpgradeInfo you wish to upgrade from
  /// containing the oldSKU and the optional prorationMode.
  static Future<PurchaserInfo> purchasePackage(Package packageToPurchase,
-      {UpgradeInfo upgradeInfo}) async {
+      {UpgradeInfo? upgradeInfo}) async {
    var response = await _channel.invokeMethod('purchasePackage', {
      'packageIdentifier': packageToPurchase.identifier,
      'offeringIdentifier': packageToPurchase.offeringIdentifier,
      'oldSKU': upgradeInfo != null ? upgradeInfo.oldSKU : null,
      'prorationMode': upgradeInfo != null && upgradeInfo.prorationMode != null


do we need to be doing upgradeInfo!.prorationMode here?

It's not needed here as upgradeInfo is a function parameter and thus the analyzer can statically make sure that it's never null.

Unwrapping would cause a compilation error.

More information about this one:
dart-lang/sdk#42626

that makes sense 👍

aboedo · 2021-02-23T14:43:12Z

lib/purchases_flutter.dart

    var response = await _channel.invokeMethod('purchasePackage', {
      'packageIdentifier': packageToPurchase.identifier,
      'offeringIdentifier': packageToPurchase.offeringIdentifier,
      'oldSKU': upgradeInfo != null ? upgradeInfo.oldSKU : null,
      'prorationMode': upgradeInfo != null && upgradeInfo.prorationMode != null
-          ? upgradeInfo.prorationMode.index
+          ? upgradeInfo.prorationMode!.index


same question here, does this need to also be unwrapping upgradeInfo?

Here we do need unwrapping as prorationMode could be implemented like this:

String? get prorationMode { if (random() < 0.5) return null; return 'RevenueCat'; }

And the analyzer can't be sure that every time upgradeInfo.prorationMode is called that the value is always null.

What I would suggest to do instead is this:

final prorationMode = upgradeInfo?.prorationMode; prorationMode != null ? prorationMode.index : null

With that we don't need to unwrap prorationMode as the analyzer knows that it can never be null.

As the analyzer can be sure that the local variable is never re-assigned to a null value after checking that it is not-null.

agreed. @vegaro we should do the updates here, even if we're safe for now since we know the current implementation of upgradeInfo won't change values for prorationMode in between calls

vegaro · 2021-02-27T01:45:15Z

Added a couple tests for the store and purchaseType null when creating entitlement info, and fixed some casts that were changed by the migration tool, but that we actually don't need.

aboedo

@vegaro looks great! good to go once we improve safety on the changed calls to proprationMode. Thanks so much @IchordeDionysos for the detailed responses to my questions!!!

aboedo · 2021-03-01T14:32:02Z

lib/purchases_flutter.dart

@@ -175,13 +175,13 @@ class Purchases {
  /// [upgradeInfo] Android only. Optional UpgradeInfo you wish to upgrade from
  /// containing the oldSKU and the optional prorationMode.
  static Future<PurchaserInfo> purchasePackage(Package packageToPurchase,
-      {UpgradeInfo upgradeInfo}) async {
+      {UpgradeInfo? upgradeInfo}) async {
    var response = await _channel.invokeMethod('purchasePackage', {
      'packageIdentifier': packageToPurchase.identifier,
      'offeringIdentifier': packageToPurchase.offeringIdentifier,
      'oldSKU': upgradeInfo != null ? upgradeInfo.oldSKU : null,
      'prorationMode': upgradeInfo != null && upgradeInfo.prorationMode != null


that makes sense 👍

aboedo · 2021-03-01T14:38:53Z

lib/purchases_flutter.dart

    var response = await _channel.invokeMethod('purchasePackage', {
      'packageIdentifier': packageToPurchase.identifier,
      'offeringIdentifier': packageToPurchase.offeringIdentifier,
      'oldSKU': upgradeInfo != null ? upgradeInfo.oldSKU : null,
      'prorationMode': upgradeInfo != null && upgradeInfo.prorationMode != null
-          ? upgradeInfo.prorationMode.index
+          ? upgradeInfo.prorationMode!.index


agreed. @vegaro we should do the updates here, even if we're safe for now since we know the current implementation of upgradeInfo won't change values for prorationMode in between calls

vegaro · 2021-03-02T03:13:37Z

Sorry I missed that one @aboedo, I actually simplified oldSKU too.

vegaro · 2021-03-03T01:27:23Z

Changed the base. This is meant to be a pre release until the final Dart version is released.

IchordeDionysos · 2021-03-03T19:34:07Z

@vegaro the new Dart version with null-safety was just released 😍
https://medium.com/dartlang/announcing-dart-2-12-499a6e689c87

So we can probably now release this 💪

vegaro · 2021-03-03T19:35:06Z

I saw that! I am actually working on the new release now :)

* migration ran * changes stable to beta * fixes tests and compilation * updates prorationMode and oldSKU

* Migrates Flutter to null safety (#155) * migration ran * changes stable to beta * fixes tests and compilation * updates prorationMode and oldSKU * prepares for version 3.0.0 (#159)

vegaro · 2021-03-03T21:58:26Z

@IchordeDionysos Just released 3.0.0

IchordeDionysos · 2021-03-03T23:16:28Z

Very cool 😍 Thanks for keeping the RevenueCat Flutter SDK always so up-to-date 💪

vegaro · 2021-03-04T00:20:40Z

Let us know if you face any issue or have any suggestion. And thanks so much for reviewing this. We really appreciate it

* Migrates Flutter to null safety (RevenueCat#155) * migration ran * changes stable to beta * fixes tests and compilation * updates prorationMode and oldSKU * prepares for version 3.0.0 (RevenueCat#159)

vegaro mentioned this pull request Feb 23, 2021

Add null safety support for upcoming Flutter version #149

Closed

vegaro linked an issue Feb 23, 2021 that may be closed by this pull request

Add null safety support for upcoming Flutter version #149

Closed

vegaro requested a review from aboedo February 23, 2021 01:15

aboedo changed the base branch from develop to removes_all_analyze_warnings February 23, 2021 14:17

aboedo changed the base branch from removes_all_analyze_warnings to develop February 23, 2021 14:17

aboedo reviewed Feb 23, 2021

View reviewed changes

vegaro added 2 commits February 23, 2021 14:06

migration ran

3a90aa8

changes stable to beta

ab982a5

vegaro force-pushed the null_safety branch from 155b133 to ab982a5 Compare February 23, 2021 22:06

fixes tests and compilation

b4b9233

vegaro requested a review from aboedo February 27, 2021 01:58

aboedo approved these changes Mar 1, 2021

View reviewed changes

updates prorationMode and oldSKU

02b56e5

aboedo approved these changes Mar 2, 2021

View reviewed changes

vegaro changed the base branch from develop to 3.x.x-release March 3, 2021 01:26

vegaro merged commit e8a18f1 into 3.x.x-release Mar 3, 2021

vegaro deleted the null_safety branch March 3, 2021 01:31

vegaro added a commit that referenced this pull request Mar 3, 2021

Migrates Flutter to null safety (#155)

80de5ef

* migration ran * changes stable to beta * fixes tests and compilation * updates prorationMode and oldSKU

vegaro added a commit that referenced this pull request Mar 3, 2021

Migrates Flutter to null safety (#155)

8bdba0c

* migration ran * changes stable to beta * fixes tests and compilation * updates prorationMode and oldSKU

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrates Flutter to null safety #155

Migrates Flutter to null safety #155

vegaro commented Feb 23, 2021 •

edited

Loading

aboedo commented Feb 23, 2021

aboedo left a comment •

edited

Loading

aboedo Feb 23, 2021

aboedo Feb 23, 2021

IchordeDionysos Feb 23, 2021 •

edited

Loading

aboedo Feb 23, 2021

aboedo Feb 23, 2021

IchordeDionysos Feb 23, 2021

IchordeDionysos Feb 23, 2021

aboedo Mar 1, 2021

aboedo Feb 23, 2021

IchordeDionysos Feb 23, 2021 •

edited

Loading

aboedo Mar 1, 2021

vegaro commented Feb 27, 2021

aboedo left a comment

aboedo Mar 1, 2021

aboedo Mar 1, 2021

vegaro commented Mar 2, 2021

vegaro commented Mar 3, 2021

IchordeDionysos commented Mar 3, 2021

vegaro commented Mar 3, 2021

vegaro commented Mar 3, 2021

IchordeDionysos commented Mar 3, 2021

vegaro commented Mar 4, 2021

Migrates Flutter to null safety #155

Migrates Flutter to null safety #155

Conversation

vegaro commented Feb 23, 2021 • edited Loading

aboedo commented Feb 23, 2021

aboedo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IchordeDionysos Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IchordeDionysos Feb 23, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro commented Feb 27, 2021

aboedo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro commented Mar 2, 2021

vegaro commented Mar 3, 2021

IchordeDionysos commented Mar 3, 2021

vegaro commented Mar 3, 2021

vegaro commented Mar 3, 2021

IchordeDionysos commented Mar 3, 2021

vegaro commented Mar 4, 2021

vegaro commented Feb 23, 2021 •

edited

Loading

aboedo left a comment •

edited

Loading

IchordeDionysos Feb 23, 2021 •

edited

Loading

IchordeDionysos Feb 23, 2021 •

edited

Loading