Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null safety support for upcoming Flutter version #149

Closed
jamesblasco opened this issue Jan 30, 2021 · 8 comments · Fixed by #155
Closed

Add null safety support for upcoming Flutter version #149

jamesblasco opened this issue Jan 30, 2021 · 8 comments · Fixed by #155
Labels
bug Something isn't working

Comments

@jamesblasco
Copy link

Flutter team is encouraging developers to migrate their packages to null safety before they release the new Flutter version that will have null safety activated by default.

https://dart.dev/null-safety/migration-guide

Right now null safety is activated by default in beta/dev/master channels and it will probably will be released in the Flutter event for 3/3/21.

I think it would be a good idea to start planning the migration before is too late

@jamesblasco jamesblasco added the bug Something isn't working label Jan 30, 2021
@vegaro
Copy link
Contributor

vegaro commented Jan 30, 2021

Hi! We were just talking about this yesterday. We have an open ticket about this and we'll take care of it. We will keep this issue open.

@muhlba91
Copy link

@vegaro any updates on the timeline for this? nnbd is in beta since a week.

@vegaro
Copy link
Contributor

vegaro commented Feb 23, 2021

I just opened a PR #155

@vegaro vegaro linked a pull request Feb 23, 2021 that will close this issue
@vegaro
Copy link
Contributor

vegaro commented Mar 3, 2021

The day has come. Just released https://pub.dev/packages/purchases_flutter 3.0.0 with minimum Dart 2.12.0 and the null safety changes 🦺

@jamesblasco
Copy link
Author

Oh wow that was fast! Thank you! 💙

@IchordeDionysos
Copy link

@jamesblasco we can now close this issue right? ☺️

@vegaro vegaro closed this as completed Mar 4, 2021
@vegaro
Copy link
Contributor

vegaro commented Mar 4, 2021

The new release has a 50 as https://pub.dev/packages/purchases_flutter/score, because the analyzer ran on Dart 2.12.0 (build 2.12.0-259.16.beta) 🤔

@vegaro
Copy link
Contributor

vegaro commented Mar 4, 2021

I just opened them an issue dart-lang/pub-dev#4582 Hopefully it's fixable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants