Cleans up CMakeLists and fixes install rules #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| install(TARGETS ${PROJECT_NAME} | ||
| LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION} | ||
| ) | ||
| install(DIRECTORY config include launch |
There was a problem hiding this comment.
Would you rather install the include dir to ${CATKIN_PACKAGE_INCLUDE_DESTINATION}?
There was a problem hiding this comment.
You're quite correct. We haven't been consistent on this, and I think the INCLUDE_DESTINATION is the correct directory. I'll update accordingly.
This fixes a few issues with CMakeLists and install rules that are required in order to release the debian packages of sawyer_simulator, and improves the build process when using catkin_make.
IanTheEngineer
force-pushed
the
cmake_lists_cleanup
branch
from
2aac6bc to
adb7785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with CMakeLists and install
rules that are required in order to release the debian
packages of sawyer_simulator, and improves the build
process when using catkin_make.