Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2615: retrieve Application list by FriendlyName #2678

Open
wants to merge 6,493 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6493 commits
Select commit Hold shift + click to select a range
b19cafb
Geolocation tutorial using Restcomm-Connect and USSD RVD, Geolocation…
Oct 20, 2017
c561d45
Update index with location based service tutorial
Oct 20, 2017
bc65e53
First attempt to improve images aspect ratio
Oct 20, 2017
e690707
Second attempt to enhance images aspect ratio
Oct 20, 2017
e52ff6e
Third attempt to improve images aspect ratio
Oct 20, 2017
298335b
Fixed typos, spelling and grammar mistakes
Oct 21, 2017
a503b96
PSAP acronym correction
Oct 23, 2017
c6b420b
updated aws java sdk version with support of adavnce route53 operatio…
Oct 24, 2017
3be7d87
updated domain query to match result even if domain name ends with do…
Oct 24, 2017
f8b817e
Addition of http-client configuration parameters for HTTP connection …
Oct 24, 2017
fa3f270
Minor comment enhancement. Issue #2594, PR #2595
Oct 24, 2017
3b1b9c5
Critical fix for making Geolocation API work with RC running on MySQL…
Oct 24, 2017
0fad039
Merge pull request #2597 from RestComm/Issue2596_GeolocationAPI_MySQL…
Oct 24, 2017
9c5bfbd
handles restcommconfig for IP/hostname and proxy
Oct 26, 2017
e79aa72
refactored pushnotification and voicerss config
Oct 26, 2017
22436af
Issue2598 fix rvd retrieval (#2600)
otsakir Oct 26, 2017
e3e8029
refactored void innovation SED
Oct 26, 2017
3bfb1df
refactored did provided config sed
Oct 26, 2017
43d2e49
Merge pull request #2595 from RestComm/Issue2594_ConnPooling_configur…
jaimecasero Oct 26, 2017
4940eb2
Initial commit for Console UI/UX revamp
ammendonca Oct 26, 2017
ceb0111
fixed fax service and sms aggregator
Oct 27, 2017
7d9d989
fixed accapella, aws polly and telestax procy config
Oct 27, 2017
e1b4018
reconfigured media and smpp
Oct 27, 2017
0dd540e
fixed external address
Oct 30, 2017
f67f42a
last refactoring
Oct 30, 2017
90fb9ce
corrected sed
Oct 30, 2017
08ad6d4
#issue 2603
Oct 30, 2017
6a509fc
added regreg in place of exact https port value
Oct 31, 2017
e0d460d
referred #2606
Oct 31, 2017
5f5be3a
fix
Oct 31, 2017
b1a4dcc
Comments added.
Oct 31, 2017
ffc8a30
Comments added.
Oct 31, 2017
2ad6813
Merge pull request #2604 from RestComm/isse2603
leftyb Oct 31, 2017
2a94583
Work in progress
gvagenas Nov 2, 2017
8f3f3ac
Merge pull request #2605 from RestComm/sslconfig
Nov 2, 2017
26bc4b7
fixed failing tests compilation
Nov 2, 2017
4f33141
this refer to #RESTCOMM-1171
Nov 2, 2017
5ba838a
commit local changes will check later
Nov 3, 2017
3e9d474
Merge branch 'master' into issue-2590
Nov 3, 2017
fec439f
started using asynch client
Nov 3, 2017
40d77d4
added LCM
Nov 3, 2017
2fe05d4
formatting and added kick
Nov 3, 2017
9af6702
Add Application Listing
otsakir Nov 3, 2017
c4fa7cc
added test to terminate conference via api
Nov 3, 2017
4bb4073
Revamp Numbers listing and Details for Web and Mobile
ammendonca Nov 3, 2017
241f354
Work in progress
gvagenas Nov 3, 2017
cf7166d
new method to count by filter. fixes https://github.com/RestComm/Rest…
jaimecasero Nov 3, 2017
853b36d
Work in progress
gvagenas Nov 3, 2017
f75f5a9
Patch for MockMediaGateway to create recording file on RQNT ES (sg=pr…
gvagenas Nov 3, 2017
46b56d1
Merge branch 'master' into restcomm1219_recording_issue
gvagenas Nov 3, 2017
b80510f
removed double quotes. SQL tested in stagin DB
jaimecasero Nov 3, 2017
2b16153
Patch for MockMediaGateway to create recording file on RQNT ES (sg=pr…
gvagenas Nov 3, 2017
ea648a7
Work in progress
gvagenas Nov 3, 2017
78d0200
Patch for MockMediaGateway to create recording file on RQNT ES (sg=pr…
gvagenas Nov 3, 2017
c5af011
trying to create a reusable asycn http client
Nov 5, 2017
d2db513
1/ ProxyManager: user name contains host part fix 2/ Set max expire t…
Nov 6, 2017
dc68ed7
build reusable CloseableHttpAsyncClient
Nov 6, 2017
8ab7acc
#2519 fixing testcases
Nov 6, 2017
4b7c374
added new actor to perform http client operation in async way
Nov 6, 2017
90ed7dc
Merge pull request #2611 from RestComm/issue2610
jaimecasero Nov 6, 2017
25415b8
Application creation and import (#2)
otsakir Nov 6, 2017
53a171c
Work in progress
gvagenas Nov 6, 2017
1de1a58
pushing pending changes
Nov 7, 2017
fdda0a3
updated access level for methods and test case
Nov 7, 2017
b9e5734
adde proper client classes for call and conference apis
Nov 7, 2017
793f114
implemented conference poststop
Nov 7, 2017
832ed07
Merge pull request #2612 from RestComm/issue-2519-1
jaimecasero Nov 7, 2017
4fc12c0
fixed issue
Nov 7, 2017
aeebd97
corrected unit test
Nov 7, 2017
1d346c2
fixed test
Nov 7, 2017
aacf91d
fixed test cases
Nov 7, 2017
17151ba
renamed
Nov 7, 2017
f89c59c
refcatoring
Nov 7, 2017
2b90186
did pending cleanup in logging
Nov 7, 2017
247ae53
Merge branch 'master' into RESTCOMM-1171
Nov 7, 2017
71dc97d
allow super admin to perform any standard secure operation
Nov 7, 2017
9ac43fa
Patch to fix Record race condition. Also provides enhancements for Mo…
gvagenas Nov 7, 2017
c807964
Merge branch 'master' into restcomm1219_recording_issue
gvagenas Nov 7, 2017
2d550a6
Merge branch 'master' of github.com:RestComm/Restcomm-Connect
gvagenas Nov 7, 2017
ddc934d
fixed sip and tomcat as test dependencies in parent.defined proper de…
jaimecasero Nov 8, 2017
528b209
fixed toString method to show fields
jaimecasero Nov 8, 2017
701c5e2
removed listPhones from dao attributes, DAO needs to be stateless.
jaimecasero Nov 8, 2017
9907c04
Fixed #2625: Update Quick Start documentation for Android BETA7
Nov 8, 2017
cbdd877
Merge pull request #2626 from RestComm/atsakiridis_issue2625
Nov 8, 2017
cee23e0
make test more stable by preventing conunt of data from previous test…
jaimecasero Nov 8, 2017
1962d85
use organizationutil to match incomingphonenumber.
jaimecasero Nov 8, 2017
f61901b
allow usage for nonSIP scenarios
jaimecasero Nov 8, 2017
92e9c92
restore previous number selection,and disable regexes for smpp
jaimecasero Nov 8, 2017
e07e84a
added test for new RegexRemover
jaimecasero Nov 8, 2017
24445f5
created notice in doc to alert about SMPP regex disable
jaimecasero Nov 8, 2017
a9eacb4
fixed counter increase
jaimecasero Nov 9, 2017
a32529d
made class to execute in parallel and some other changes as per revie…
Nov 9, 2017
a5747d0
fixes subsequent regex removal
jaimecasero Nov 9, 2017
af93f70
LiveCallModificationTest modified to test LiveCall and Mgcp metrics
gvagenas Nov 9, 2017
d2ced7f
Merge pull request #2628 from RestComm/issue2627
Nov 9, 2017
a52b6e5
Merge branch 'master' of github.com:RestComm/Restcomm-Connect
gvagenas Nov 9, 2017
7359b00
replace / with | filter char
Nov 10, 2017
d44b8b9
Merge branch 'master' into RESTCOMM-1171
Nov 10, 2017
99c1591
handled bad request
Nov 10, 2017
92a4033
i added this check for superadmin in conference and call endpoints in…
Nov 10, 2017
9f17919
made call/conference api client to be disposeable (used for one requ…
Nov 10, 2017
ff63f55
Merge pull request #2629 from RestComm/issue2627
jaimecasero Nov 10, 2017
b1ced3b
External RVD import selection (#3)
otsakir Nov 10, 2017
9118e8a
Revamp Logs listing for Desktop view
ammendonca Nov 10, 2017
dc6f651
Merge branch 'master' into testCategories
jaimecasero Nov 12, 2017
f29929c
added unstable beased on latest test results from CI
jaimecasero Nov 13, 2017
bbe2e99
let requesting account be incharge of terminating conference/calls
Nov 13, 2017
f2e3c56
Merge pull request #2631 from RestComm/testCategories
jaimecasero Nov 13, 2017
27a247f
dedicate callmanager to hangup, seperating local and remote calls
Nov 13, 2017
47b1268
updated conference documentation
Nov 13, 2017
299f3c9
corrected the actor creation
Nov 13, 2017
b4e6389
implemented timeout
Nov 13, 2017
585b102
check style fix
Nov 13, 2017
0303a1f
changed timeout unit
Nov 13, 2017
1c08e8c
Updated quick start for beta.5.
Nov 13, 2017
9b7df20
Merge pull request #2632 from ognjenns/master
Nov 13, 2017
9590d8f
added unit test for actor cleanup and some code optimisation
Nov 13, 2017
c509be6
Revamp Logs listing for Mobile view
ammendonca Nov 14, 2017
7cb9006
UI/UX fixes from Console Review/Brainstorm
ammendonca Nov 15, 2017
183717c
Merge branch 'master' into RESTCOMM-1171
Nov 15, 2017
6b2fc12
revert conferencet termination api changed and made conference actor …
Nov 15, 2017
3346140
remove space for better diff
Nov 15, 2017
2a10bd9
reverse conference tool test class
Nov 15, 2017
853d9c5
created a new wrapper for callapiresponse instead od reusing download…
Nov 15, 2017
11ebe24
remove new param from StopConference
Nov 15, 2017
1085574
changed assertion mechanism to debug test
Nov 16, 2017
1135ec5
using parent4 and new smpp dependency
jaimecasero Nov 16, 2017
b613042
Additional fixes to Accounts view
ammendonca Nov 16, 2017
d24e657
Update font-awesome to v4.7.0
ammendonca Nov 16, 2017
ef25d4f
annotations for test categories added here to be reused across project
jaimecasero Nov 17, 2017
ca24df5
using parallelclass annotation
jaimecasero Nov 17, 2017
7d8d88b
Merge branch 'master' into issue-2590
Nov 17, 2017
26ba173
replaced sed char / with |
Nov 17, 2017
5a6935b
ms config correction
Nov 17, 2017
6562a1c
corrected external address
Nov 17, 2017
3047e87
changed inline replace for pns and vi
Nov 17, 2017
1eb42d0
Merge pull request #2613 from RestComm/issue-2590
Nov 17, 2017
03517eb
Review and Finalize Applications view (#4)
otsakir Nov 17, 2017
18652cd
Revamp of "Register Number" for Desktop and Mobile
ammendonca Nov 18, 2017
c60bc31
fixed readme to include new Jenkins URL
jaimecasero Nov 20, 2017
c3f1eb5
added jenkinsfile for pipeline plugin
jaimecasero Nov 20, 2017
b44fe4e
added slave node label
jaimecasero Nov 20, 2017
0073875
Patch to properly remove participant from Conference.
gvagenas Nov 20, 2017
3355b76
fixes https://github.com/RestComm/Restcomm-Connect/issues/2644
jaimecasero Nov 21, 2017
ca80ab2
added testsuite stage
jaimecasero Nov 21, 2017
4b1d05d
removed unsused resources
jaimecasero Nov 21, 2017
a017b75
Merge branch 'master' into issue1233_agg
jaimecasero Nov 21, 2017
d3bcf51
3 stages defined
jaimecasero Nov 21, 2017
539000c
added stability plugin to testresult
jaimecasero Nov 21, 2017
9bac03a
Merge branch 'master' into issue1233_agg
jaimecasero Nov 21, 2017
5450252
Merge branch 'master' into test_annos
jaimecasero Nov 21, 2017
ef90ff8
answerdelay are featurealt
jaimecasero Nov 21, 2017
60ddb63
withinminutes tests
jaimecasero Nov 21, 2017
e7b82b5
added NewTests category after design review
jaimecasero Nov 21, 2017
04b31ed
Fixes to mid-size ("tablet") layout plus enhancements
ammendonca Nov 22, 2017
d77721b
added java doc for categories and removed Stable Tests category, by d…
Nov 22, 2017
d7e1c8b
categorized CallLifecycleTest
Nov 22, 2017
9edeb23
categories are not actually annotations
jaimecasero Nov 22, 2017
3335dba
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
jaimecasero Nov 22, 2017
0a90955
Merge branch 'master' into smpp_deps
jaimecasero Nov 22, 2017
dd855b0
pointing to released version
jaimecasero Nov 22, 2017
ecb9e2e
fixed after merge
jaimecasero Nov 22, 2017
9357ada
exluding unstable and borken by now
jaimecasero Nov 22, 2017
b61a436
added Exp category in CallLifeCycleTest
Nov 22, 2017
ce6bef2
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
95f1c59
categorised CallLifecycleAnswerDelayTest
Nov 22, 2017
51c9144
removed FeatureCoreTest category
Nov 22, 2017
b7f5fc1
categorised `Clients`
Nov 22, 2017
87b4306
renamed the test class to be included in CI
Nov 22, 2017
fdf48bc
Categorization for DialRecord* tests
gvagenas Nov 22, 2017
555f41d
Merge branch 'test_annos' of github.com:RestComm/Restcomm-Connect int…
gvagenas Nov 22, 2017
69c5620
Categorization for DialFok* tests
gvagenas Nov 22, 2017
1a5d15c
corrected organization test case
Nov 22, 2017
4616915
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
16afa52
increased time to make it stable
Nov 22, 2017
776c598
fixed Callback
Nov 22, 2017
3de6a25
categorised http intial 7 classes
Nov 22, 2017
970858b
http first 17 classes categorised
Nov 22, 2017
63216dc
added FeatureCore category
jaimecasero Nov 22, 2017
3ae5391
Categorization for ImsClientDial* tests
gvagenas Nov 22, 2017
d179172
Categorization for NoAuthRegisterClientTest tests
gvagenas Nov 22, 2017
51a0631
Merge branch 'test_annos' of github.com:RestComm/Restcomm-Connect int…
gvagenas Nov 22, 2017
44e558f
initial smpp pck category, check results in CI.locally all failing
jaimecasero Nov 22, 2017
d3ce9d7
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
jaimecasero Nov 22, 2017
14e63c9
fixes quotes for categories
jaimecasero Nov 22, 2017
933b3ea
categorised LCM classes
Nov 22, 2017
d77616b
Categorization for tests
gvagenas Nov 22, 2017
bc8a089
Merge remote-tracking branch 'origin/test_annos' into test_annos
gvagenas Nov 22, 2017
0ac3a75
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
a64a4de
categories applied to sms pck
jaimecasero Nov 22, 2017
1a2fadb
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
jaimecasero Nov 22, 2017
3c1de46
categorised http pack complete
Nov 22, 2017
16e6637
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
dd34411
Categorization for tests
gvagenas Nov 22, 2017
7d1ae7d
categorised number provisioning pkg tests
Nov 22, 2017
b58f445
marking broken after first ci resutls on smpp
jaimecasero Nov 22, 2017
5b009dd
remove unused imports
Nov 22, 2017
e20a864
adde parallel step
jaimecasero Nov 22, 2017
c182aa0
fixed checkout phase
jaimecasero Nov 22, 2017
572df2b
using stage block
jaimecasero Nov 22, 2017
d504978
fixing stash
jaimecasero Nov 22, 2017
13c984c
removed core category and added a new broken test
Nov 22, 2017
bff4848
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
6261190
Merge branch 'test_annos' of https://github.com/RestComm/Restcomm-Con…
Nov 22, 2017
dfc6f01
removed invalid steps block
jaimecasero Nov 22, 2017
be0f364
added checkout scm before testuite
jaimecasero Nov 22, 2017
073852a
added compile before test
jaimecasero Nov 22, 2017
a27ad4b
allow forkCount to be overriden from command line/CI
jaimecasero Nov 22, 2017
47ddcb2
changed quoting to ensure group filtering
jaimecasero Nov 22, 2017
3fcc862
escape \ char
jaimecasero Nov 22, 2017
3c61fbf
fixed closing quote
jaimecasero Nov 22, 2017
d962b00
fixes parallel test
jaimecasero Nov 23, 2017
52ed056
allow parallel with surefire in profile
jaimecasero Nov 23, 2017
676dbb3
run sequential test in same node
jaimecasero Nov 23, 2017
50d1bbd
prevent long sleep in test
jaimecasero Nov 23, 2017
9ceeaed
added new unstable test as per inconsistency of their results
Nov 23, 2017
92328c2
Fixes typo in ClientConverter
otsakir Nov 23, 2017
1e2a0b3
more unstable from latest ci run
jaimecasero Nov 23, 2017
7017384
comments and echoing env vars
jaimecasero Nov 23, 2017
f944ed3
run test in maven target dir
jaimecasero Nov 23, 2017
d5701ae
more unstable from latest ci run
jaimecasero Nov 23, 2017
b8fd06f
Merge branch 'master' into smpp_deps
jaimecasero Nov 23, 2017
4abce85
Merge pull request #2662 from RestComm/issue2657_client_missing_voice…
Nov 23, 2017
c66a6c9
remove parallel nodes
jaimecasero Nov 23, 2017
f4a52ae
Merge branch 'master' of https://github.com/RestComm/Restcomm-Connect
jaimecasero Nov 23, 2017
e62d928
Implement workaround on retrieval and display of numbers in applicati…
otsakir Nov 23, 2017
eba3f43
Display all applications (RVD+external) in request urls dropdowns
otsakir Nov 23, 2017
cbfb244
Merge pull request #2666 from RestComm/smpp_deps
jaimecasero Nov 23, 2017
d4d6ba8
Add sorting to Numbers, Logs/Calls, Apps, Clients, Sub-Accounts
ammendonca Nov 24, 2017
031b0a5
fixes https://github.com/RestComm/Restcomm-Connect/issues/2669
jaimecasero Nov 24, 2017
0519406
Preserved url fragment through logins
otsakir Nov 24, 2017
7abf1df
Removed "Create new project" from Number details
otsakir Nov 24, 2017
28fff46
Merge branch 'master' into issue1233_agg
jaimecasero Nov 24, 2017
2a222b5
More Console fixes to styles and functionalities
ammendonca Nov 25, 2017
3e39140
unstable from ci
jaimecasero Nov 25, 2017
aa979e4
Merge pull request #2670 from RestComm/bug-2669
gvagenas Nov 27, 2017
ec69d50
fixed tests reported by CI
jaimecasero Nov 27, 2017
6e16b19
Changed Restcomm Sip Servlets binary url to box.com
gvagenas Nov 27, 2017
345697c
Improvements to Logs pages in inner-links
ammendonca Nov 27, 2017
02c5c2d
Changed Restcomm Sip Servlets binary url
gvagenas Nov 27, 2017
4f6e1b5
Merge pull request #2645 from RestComm/issue1233_agg
jaimecasero Nov 27, 2017
7e1b40f
Fixes for build.xml
gvagenas Nov 28, 2017
4ec5f3d
Merge branch 'master' of github.com:RestComm/Restcomm-Connect
gvagenas Nov 28, 2017
bcb272f
Fixes for build.xml
gvagenas Nov 28, 2017
7a7efaa
Merge pull request #2674 from ammendonca/CONSOLE-UI/UX-REVAMP
ammendonca Nov 28, 2017
c70afd4
Fixed broken client creation in Console
otsakir Nov 29, 2017
4e8dfe2
Merge pull request #2617 from RestComm/RESTCOMM-1171
Nov 30, 2017
3deae73
add application filters in DAO layers
ddhuy Nov 30, 2017
0588c1d
add java file
ddhuy Dec 2, 2017
2a57402
add testsuite
ddhuy Dec 15, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,8 @@ bin/
*.class
logs
bin
.DS_Store
**/*~
csv
.metadata
.idea
13 changes: 13 additions & 0 deletions .idea/codeStyleSettings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
language: java
jdk:
- oraclejdk8
branches:
only:
- master
- /^deploy-.*$/
email:
recipients:
- gvagenas@telestax.com
- jean.deruelle@telestax.com
on_success: never # default: change
on_failure: always # default: always
cache:
directories:
- $HOME/.m2
addons:
sonarqube:
organization: "restcomm-connect" # the key of the org you chose at step #3
script:
- ./build.sh
after_success:
- cd restcomm
- mvn com.blackducksoftware.integration:hub-maven-plugin:2.0.2:build-bom -Dhub.output.directory=. -Dhub.deploy.bdio=false
- bash <(curl -s https://copilot.blackducksoftware.com/bash/travis) ./*_bdio.jsonld
# Problem to run testsuite https://github.com/travis-ci/travis-ci/issues/1382
# - echo "About to run sonar-scanner"
# - cd restcomm
# - pwd
# - sed -i 's/\<root\>/\<!--root>/g' ./restcomm.testsuite/src/test/resources/log4j.xml
# - sed -i 's/\<\/root\>/\<\/root-->/g' ./restcomm.testsuite/src/test/resources/log4j.xml
# - sed -i 's/DEBUG/OFF/g' ./restcomm.testsuite/src/test/resources/akka_application.conf
# - sed -i 's/INFO/OFF/g' ./restcomm.application/src/main/resources/application.conf
# - mvn -q clean org.jacoco:jacoco-maven-plugin:prepare-agent surefire-report:report sonar:sonar > ./surefire-report-output.txt
# - curl -T restcomm.testsuite/target/site/surefire-report.html -ugvagenas:$BINTRAY_API_KEY -H "X-Bintray-Package:binaries" -H "X-Bintray-Version:8.2.0" https://api.bintray.com/content/gvagenas/Restcomm-Connect/bin/surefire-report-$MAJOR_VERSION_NUMBER.$BUILD_NUMBER.html
# - curl -T ./surefire-report-output.txt -ugvagenas:$BINTRAY_API_KEY -H "X-Bintray-Package:binaries" -H "X-Bintray-Version:8.2.0" https://api.bintray.com/content/gvagenas/Restcomm-Connect/bin/surefire-report-output-$MAJOR_VERSION_NUMBER.$BUILD_NUMBER.txt
1,223 changes: 1,223 additions & 0 deletions CHANGELOG_8.2.1.md

Large diffs are not rendered by default.

282 changes: 282 additions & 0 deletions CONTRIBUTING.asciidoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,282 @@
= Contribute to Restcomm

Multiple types of contributions are possible :

* Using it in your product or project and providing feedback.
* Code & Algorithms: Core Projects, Incubator projects, Frameworks
* Use cases, feature requests: Roadmap influence
* Community Support, bug fixes, forum posts: Help to be helped
* Documentation: Everyone needs good docs, Code is a moving targed.
* Testing (Perf, load, security, unit tests, interop, ...) / CI

Here is specific types of contributions that requires a little more details if you want to get involved

* Fixing Bugs : See https://help.github.com/articles/closing-issues-via-commit-messages
* Reporting Bugs : To report a bug, if possible, provide a small example that illustrates the bug. You can pattern
the test case usually along the lines of ones found in the
link:https://github.com/Restcomm/Restcomm-Connect/tree/master/restcomm/restcomm.testsuite[testsuite].
Having a test case handy speeds up the bug fix. Your test case will be included in the project as a test case.
Open an Issue as defined in the section below so other users can know about the issue and its status.
Please attach your test case or bug description with debug log files there.
* Contributing Extensions and enhancements (i.e. support for extension RFCs and drafts that are not covered by
Restcomm) or Contributing code snippets and examples or Contributing test cases to be included with the
distribution: See Contribution Process below in Section "How to check out, change, review, and commit code".
Also open a thread on link:http://groups.google.com/group/restcomm[the mailing list of Restcomm google group]
to discuss it with the community and Restcomm Team Members.

Your contributions will be acknowledged individually in the code (as a comment) and in the
link:http://www.telestax.com/opensource/#Contribute[Acknowledgement page].


= Opening an Issue

link:https://github.com/Restcomm/Restcomm-Connect/issues/new[Open An Issue Here]

= Becoming a Contributor

In order to become a contributor with write access to the code, you will need to have demonstrated an understanding
of the codebase and testsuite by participating in the design discussions and submitting patches for bugs/enchancements
before we will grant developer access.

Contributing to Restcomm requires you to accept link:http://telestax.com/opensource/[the TeleStax Contributor Agreement]
(bottom of the page).

= How to check out, change, review, and commit code
== Introduction

Restcomm projects use Git, a distributed version control system. What this means is that, even though this page hosts
a central repository, there can be many clone repositories with changes of their own, and then some of those can be
merged back into the main repository.

*The great part is that you can start contributing and create our own clone without having write access to the
Restcomm repository*

This document describes the workflow for checking out code, making clones, reviewing patches, and committing code.

== Checking out Restcomm Connect (Linux)

For non-committers, checking out code is simple.

=== Install Git

Follow the installing Git instructions. Ubuntu users can simply type:

[source,bash]
----
sudo apt-get install git-core
----

Configure Git to convert line endings on commit

[source,bash]
----
git config --global core.autocrlf input
----

=== Checkout the code

To check out the code :

[source,bash]
----
git clone git@github.com:Restcomm/Restcomm-Connect.git
----


=== Building Restcomm From Source
To Build Restcomm from Source, follow those instructions : http://docs.telestax.com/restcomm-mobicents-building-from-source/


=== Committing code

The following License Header has to be placed on top of each source code file contributed

[source,java]
----
/*
* TeleStax, Open Source Cloud Communications
* Copyright 2011-2015, Telestax Inc and individual contributors
* by the @authors tag.
*
* This program is free software: you can redistribute it and/or modify
* under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation; either version 3 of
* the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
----

The model we've chosen for developing Restcomm is the following:

Each contributor creates their own fork of the Restcomm project (you want to contribute to) repository.

This clone is hosted on Github servers, and can be created by clicking *Fork* button from
https://github.com/Restcomm/Restcomm-Connect

The contributor then makes a local clone of their GitHub fork, which is stored on their local machine.
Instructions for checking it out is https://github.com/<contributor_github_account>/Restcomm

The contributor creates a new Issue explaining their contribution at
https://github.com/Restcomm/Restcomm-Connect/issues/new

The contributor then creates a new branch into their local clone

[source,bash]
----
git checkout -b feature-branch
----

Do the changes into their branch for their local branch for the contribution and commit them

[source,bash]
----
git commit -a -m "commit message"
----

**//IMPORTANT//:Please use the Github integration to use the commit message to tie the commits to the Issue you're
working on. More information on that can be found at https://help.github.com/articles/closing-issues-via-commit-messages**

**//IMPORTANT//: When your change is pulled into the main Restcomm source, the change description that you entered here
will show up as changes in the main Restcomm source, so please use a meaningful description - fixing bug, making
changes, etc. are not ok, please instead use something like fixing transform bug caused by NPE, etc. so that it makes
sense in the context of Restcomm as a whole, not just your clone.**

If you have any new files, make sure to use the following command before committing

[source,bash]
----
git add <file or directory>
----

Same thing if you want to remove some files

[source,bash]
----
git rm <file or directory>
----

== Pushing changes to your online clone

When a change is ready to be integrated back into the repository, that change is pushed from the developer's local
clone to their Github Fork clone.

[source,bash]
----
git push origin feature-branch
----

To avoid merge soup, please rebase your branch first

==== Bringing in new changes from the upstream repository

If the main repository has evolved since your last push to your clone repository, you will need to bring those changes
into your repository as well as potentially merge them.

You need to add a remote via which you will identify the upstream repository:

[source,bash]
----
git remote add upstream git@github.com:Restcomm/Restcomm-Connect.git
----

Now whenever you want to merge upstream changes into your clone, do the following:

[source,bash]
----
git fetch upstream
git merge upstream/master
----

==== Pushing changes to your clone repository

First pull in all of the latest changes from upstream, apply them to your master branch, then rebase your feature
branch against master before merging it into master and pushing it upstream:

[source,bash]
----
git checkout master
git fetch upstream
git merge upstream/master
git checkout awesome-feature
git rebase master
(fix any conflicts with upstream changes)
git push origin feature-branch
----

Browse to Source -> Changes from the project page for your clone and navigate to the page with details on the branch
to be reviewed. For example, https://github.com/<contributor_github_account>/Restcomm/tree/development

You will need to paste the URL for this page into the issue you created earlier.
Describe the code to be reviewed, its purpose, and paste in the URL for the relevant changeset(s) or branch(es).

The code will be reviewed on the contributor's clone - if any further changes are suggested, a couple of iterations
might be needed so the contributor will need to modify the code again, commit, push and comment on the issue.

Once the change is approved, a committer of Restcomm will merge it back into the main repository with the following
commands.

[source,bash]
----
git checkout -b feature-branch
git pull https://github.com/<contributor_github_account>/Restcomm/ feature-branch
git checkout master
git merge feature-branch
----

Even though this may sound complicated, this process makes code reviews easier and allows a lot of people to work on
changes in parallel.

==== Code formatting

In order to avoid merge conflicts, be it with new features or bug fixes, Restcomm takes advantage of maven code
formatting plugin. By default, all of our projects trigger this plugin during build. It provides information on code
style and violations of certain rules.
Example failure may look as follows:

[source,bash]
----
[INFO] Starting audit...
/home/baranowb/Restcomm/git/test/src/main/java/Test.java:46: Line has trailing spaces.
/home/baranowb/Restcomm/git/test/src/main/java/Test.java:47:1: '{' should be on the previous line.
/home/baranowb/Restcomm/git/test/src/main/java/Test.java:50: Line has trailing spaces.
Audit done.
----

Contributor responsibility is to provide us with code, which obeys formatting rules. If source does not pass code
style checks, it won't be accepted!

===== IDE formatting support

IDEs have native support for formatting. To take advantage of it, you need to import configuration files.
Restcomm has projects wide configuration for IDEs. It can be found here:
http://grepcode.com/snapshot/repo1.maven.org/maven2/org.mobicents/checkstyle/1.0.0.FINAL/
or in any tagged relase of this artifact.

===== Eclipse
To import formatter rules into eclipse perform following:

* Window > Preferences > Java > Code Style > Clean Up > 'Import' -> cleanup.xml
* Window > Preferences > Java > Code Style > Formatter > 'Import' -> formatter.xml

Optionally:
* Window > Preferences > Java > Code Style > Code Templates > 'Import' -> templates.xml

===== Maven checkstyle configuration

The checkstyle plugin is pre-configured in mobicents-parent artifact. To enable it in any subproject which depends on it, you need to add only following lines in *plugins* section of master project pom:

[source,xml]
----
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
</plugin>
----
30 changes: 30 additions & 0 deletions Jenkinsfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
node("cxs-ups-testsuites_large") {
echo sh(returnStdout: true, script: 'env')

stage ('Checkout') {
checkout scm
}

stage ("Build") {
// Run the maven build with in-module unit testing
sh "mvn -f restcomm/pom.xml -T 1.5C clean install -pl \\!restcomm.testsuite -Dmaven.test.failure.ignore=true -Dmaven.test.redirectTestOutputToFile=true"
//keep this build for later use
junit '**/target/surefire-reports/*.xml'
//prevent to report this test results two times
sh "mvn -f restcomm/pom.xml clean"
}

stage("CITestsuiteSeq") {
sh 'mvn -f restcomm/restcomm.testsuite/pom.xml clean install -DskipUTs=false -Dmaven.test.failure.ignore=true -Dmaven.test.redirectTestOutputToFile=true -Dfailsafe.rerunFailingTestsCount=0 -DexcludedGroups="org.restcomm.connect.commons.annotations.ParallelClassTests or org.restcomm.connect.commons.annotations.UnstableTests or org.restcomm.connect.commons.annotations.BrokenTests"'
junit testResults: '**/target/surefire-reports/*.xml', testDataPublishers: [[$class: 'StabilityTestDataPublisher']]
//prevent to report this test results two times
sh "mvn -f restcomm/pom.xml clean"
}

stage("CITestsuiteParallel") {
sh 'mvn -f restcomm/restcomm.testsuite/pom.xml clean install -Pparallel-testing -DforkCount=16 -Dmaven.test.failure.ignore=true -Dmaven.test.redirectTestOutputToFile=true -Dfailsafe.rerunFailingTestsCount=0 -Dgroups="org.restcomm.connect.commons.annotations.ParallelClassTests" -DexcludedGroups="org.restcomm.connect.commons.annotations.UnstableTests or org.restcomm.connect.commons.annotations.BrokenTests"'
junit testResults: '**/target/surefire-reports/*.xml', testDataPublishers: [[$class: 'StabilityTestDataPublisher']]
//prevent to report this test results two times
sh "mvn -f restcomm/pom.xml clean"
}
}
Loading