Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2615: retrieve Application list by FriendlyName #2678

Open
wants to merge 6,493 commits into
base: master
Choose a base branch
from

Conversation

ddhuy
Copy link

@ddhuy ddhuy commented Nov 30, 2017

Add application filters in DAO layers

Fernando Mendioroz and others added 30 commits October 20, 2017 03:26
… and SMS API, GMLC, USSD Gateway and SIP Phone
Create a simple emergency location based service.adoc added
…ns, tested s3 upload with this version and its working like a charm
…PI_MySQL_error

Critical fix for making Geolocation API work with RC running on MySQL
build.xml will fetch RVD from github/releases instead of mobicents

Refers RestComm#2598
…configuration

Addition of http-client configuration params for HTTP conn pooling
Home, Accounts, Sub-Accounts, Analytics and Clients pages already changed
@ddhuy ddhuy mentioned this pull request Nov 30, 2017
@ddhuy
Copy link
Author

ddhuy commented Nov 30, 2017

@gsaslis , Please can you help review this fix

@ddhuy ddhuy changed the title Issue 2615 Issue 2615: retrieve Application FriendlyName Nov 30, 2017
@ddhuy ddhuy changed the title Issue 2615: retrieve Application FriendlyName Issue 2615: retrieve Application list by FriendlyName Nov 30, 2017
Copy link
Contributor

@gsaslis gsaslis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ddhuy,

Would you kindly add some tests around the new functionality you are introducing with this PR?

Take a look here for some ideas on how to approach writing these tests

@ddhuy
Copy link
Author

ddhuy commented Dec 15, 2017

@gsaslis , Thanks for your comments. I have just add new tests for the new functionality and fix some old test problems.

@gsaslis
Copy link
Contributor

gsaslis commented Jan 25, 2018

Thanks @ddhuy and apologies for the delayed response here.

Will request review from core team.

@gsaslis gsaslis requested review from a team and removed request for gvagenas, ghjansen and maria-farooq February 9, 2018 11:10
@gvagenas gvagenas force-pushed the master branch 2 times, most recently from 9469191 to c67f142 Compare January 13, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants