Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue2598 fix rvd retrieval #2600

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Issue2598 fix rvd retrieval #2600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757af32
Update build.xml to fetch RVD from cxs
otsakir Oct 25, 2017
9765991
build.xml will fetch RVD from github/releases instead of mobicents
otsakir Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
Result assigned to: restcomm-rvd.download.url
-->
<property name="restcomm-rvd.path" value="${configuration.directory}/restcomm-rvd.war"/>
<condition property="restcomm-rvd.download.url" value="https://oss.sonatype.org/content/groups/public/org/restcomm/restcomm-connect-rvd/${rvd.version}/restcomm-connect-rvd-${rvd.version}.war" else="https://mobicents.ci.cloudbees.com/view/VisualDesigner/job/VisualDesigner/lastSuccessfulBuild/artifact/designer/target/restcomm-rvd.war">
<condition property="restcomm-rvd.download.url" value="https://oss.sonatype.org/content/groups/public/org/restcomm/restcomm-connect-rvd/${rvd.version}/restcomm-connect-rvd-${rvd.version}.war" else="https://cxs.restcomm.com/view/Upstream/job/UPS_VisualDesigner/lastSuccessfulBuild/artifact/designer/target/restcomm-rvd.war">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better not to use views in the url, but is small detail..

is the script ready to authenticate against CXS to get the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up using github releases instead of cxs

<isset property="rvd.version"></isset>
</condition>
<echo>Will retrieve RVD from ${restcomm-rvd.download.url}</echo>
Expand Down