Issue2598 fix rvd retrieval #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecasero
reviewed
Oct 26, 2017
release/build.xml
Outdated
| @@ -45,7 +45,7 @@ | |||
| Result assigned to: restcomm-rvd.download.url | |||
| --> | |||
| <property name="restcomm-rvd.path" value="${configuration.directory}/restcomm-rvd.war"/> | |||
| <condition property="restcomm-rvd.download.url" value="https://oss.sonatype.org/content/groups/public/org/restcomm/restcomm-connect-rvd/${rvd.version}/restcomm-connect-rvd-${rvd.version}.war" else="https://mobicents.ci.cloudbees.com/view/VisualDesigner/job/VisualDesigner/lastSuccessfulBuild/artifact/designer/target/restcomm-rvd.war"> | |||
| <condition property="restcomm-rvd.download.url" value="https://oss.sonatype.org/content/groups/public/org/restcomm/restcomm-connect-rvd/${rvd.version}/restcomm-connect-rvd-${rvd.version}.war" else="https://cxs.restcomm.com/view/Upstream/job/UPS_VisualDesigner/lastSuccessfulBuild/artifact/designer/target/restcomm-rvd.war"> | |||
There was a problem hiding this comment.
better not to use views in the url, but is small detail..
is the script ready to authenticate against CXS to get the file?
There was a problem hiding this comment.
Ended up using github releases instead of cxs
maria-farooq
pushed a commit
that referenced
this pull request
Nov 3, 2017
* master: fixed failing tests compilation Comments added. Comments added. fix referred #2606 added regreg in place of exact https port value #issue 2603 Issue2598 fix rvd retrieval (#2600) Minor comment enhancement. Issue #2594, PR #2595 Addition of http-client configuration parameters for HTTP connection pooling, commented for now as agreed. Issue #2594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates build.xml so that it fetches rvd from github releases.
A custom build has been created and seems to work fine.
Related to issue #2598