Issue 2519 #2530

xhoaluu · 2017-09-29T10:33:32Z

…on for tests.

# Conflicts: # restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/RecordingsEndpoint.java

…ord for MariaDB script. Issue #1551.

…teTadhackEnvironment

…Environment # Conflicts: # restcomm/restcomm.application/src/main/webapp/WEB-INF/data/hsql/restcomm.script # restcomm/restcomm.application/src/main/webapp/WEB-INF/scripts/mariadb/init.sql

…1945.

# Conflicts: # restcomm/restcomm.application/src/main/webapp/WEB-INF/data/hsql/restcomm.script # restcomm/restcomm.application/src/main/webapp/WEB-INF/scripts/mariadb/init.sql # restcomm/restcomm.dao/src/main/java/org/restcomm/connect/dao/mybatis/MybatisRecordingsDao.java # restcomm/restcomm.interpreter/src/main/java/org/restcomm/connect/interpreter/BaseVoiceInterpreter.java

…rb. Issue #1552.

." This reverts commit 1e7fadb.

…cipant media session. Issue #1552.

…video conferencing RCMLs. Issue #1552.

…ns, tested s3 upload with this version and its working like a charm

…t (.)

…pooling, commented for now as agreed. Issue #2594

…. Issue #2596

…_error Critical fix for making Geolocation API work with RC running on MySQL

build.xml will fetch RVD from github/releases instead of mobicents Refers #2598

…ation Addition of http-client configuration params for HTTP conn pooling

Remove port for Provider DID URI when SRV enabled.

added regreg in place of exact https port value

jaimecasero · 2017-11-02T08:39:55Z

...comm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/proxy/ProxyManager.java

@@ -103,13 +104,18 @@ private Address contact(final Gateway gateway, final int expires) throws Servlet
        if (outboundInterface == null)
            outboundInterface = (SipURI) factory.createSipURI(null, address);
        final String user = gateway.getUserName();
+        String contactUser = new String (user);


i think this "new String" is not strictly neccesary...

You are right, to be updated.

jaimecasero · 2017-11-02T08:52:20Z

...testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/proxy/ProxyManagerTest.java

-    private static SipStackTool tool;
-    private SipStack receiver;
-    private SipPhone phone;
+    final String deploymentUrl = "http://127.0.0.1:8080/restcomm/";


maybe is a good time to refactor thsi test to support parallelization, see other test to check how it goes

updated to parallel test

jaimecasero · 2017-11-02T09:02:18Z

...testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/proxy/ProxyManagerTest.java

+        final String userName = "august@127.0.0.1:5092";
+        isAuthorizationHasRightUserName = false;
+        isRegisterRequestReceived = false;
+        ExecutorService executorService = Executors.newSingleThreadExecutor();


any reason to do this async to the test thread, why dont ew simple set the Gateway,and then proceed with traffic assertions?

we may need to declare those asserting flags as volatile if several threads are read/writing them..

As the time, copied pasted without evaluating.
I removed the parallel code and also removed the check variables, put direct assert at the point as we don't use thread any more.

jaimecasero · 2017-11-02T09:04:02Z

...testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/proxy/ProxyManagerTest.java

+            }
+        });
+
+        RestcommCallsTool.getInstance().setGateWay(deploymentUrl, adminAccountSid, adminAuthToken, "friendlyName", 


should we asssert something on response, to ensure the response is as expected?

As response is from simulator, then nothing to check there.
I changed the testcase name, then it's cleared about the target for the testcase.
I just need to check if username has host part, REGISTER can be sent out and the username in authentication header in REGISTER request is what we want.

jaimecasero · 2017-11-02T09:05:20Z

.../restcomm.testsuite/src/test/java/org/restcomm/connect/testsuite/http/RestcommCallsTool.java

+
+        String response = null;
+        try {
+            response = webResource.accept(MediaType.APPLICATION_XML).post(String.class, params);


why are we using XML here, most of the testsuite is using JSON as response format to ease parsing later...

updated follow comment.

jaimecasero · 2017-11-02T09:10:34Z

...comm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/proxy/ProxyManager.java

        final String host = outboundInterface.getHost();
        int port = outboundInterface.getPort();
        if (port == -1) {
            port = outboundInterface().getPort();
        }
        final StringBuilder buffer = new StringBuilder();
-        buffer.append("sip:").append(user).append("@").append(host).append(":").append(port);
+        buffer.append("sip:").append(contactUser).append("@").append(host).append(":").append(port);


would be great to create meaningful constants fro "@" and ":" is all over the place...

There is a lot of place where is using @ and : .
We need to create a common place to define all of these thing. It's would be great in another story for refactoring code.

… register header

…ct if it's already in 3. adding testcase for proxyManagerTest

ghjansen and others added 30 commits January 18, 2017 18:17

Fixes #1726.

63ef982

Enabling video for Restcomm with XMS, also including a play applicati…

4f7cd59

…on for tests.

Including video file for demo call. Issue #1551.

c727d4d

Merge branch 'master' into Issue1551_PlayVideoFileRCML

e3dcd9b

Preliminar structure for video recording. Issue #1767.

6caa4e1

Video recording. Issue #1767.

8217369

Merge branch 'master' into Issue1767_RecordVideoRCML

29a8c64

Fix for downloading recording files with WAV and MP4 extensions. Issue …

da07485

…#1767.

Merge branch 'master' into Issue1767_RecordVideoRCML

bbc13a5

# Conflicts: # restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/RecordingsEndpoint.java

Inclusion of parameters for JSR 309. Issue #1941.

57b1874

Fix usage of parameters for JSR 309 connector. Issue #1941.

8582258

fixed restcomm side issue with #1942

7299df4

Merge branch 'master' into issue1726_CallerRejectNotification

735b365

Filename standardisation for video demos and inclusion of missing rec…

f63fc10

…ord for MariaDB script. Issue #1551.

Merge branch 'master' into Issue1551_PlayVideoFileRCML

c618e05

Merge branch 'master' into Issue1767_RecordVideoRCML

2877e98

Merge branch 'issue1726_CallerRejectNotification' into Issue1945_Upda…

2163dd2

…teTadhackEnvironment

Merge branch 'Issue1767_RecordVideoRCML' into Issue1945_UpdateTadhack…

839185e

…Environment # Conflicts: # restcomm/restcomm.application/src/main/webapp/WEB-INF/data/hsql/restcomm.script # restcomm/restcomm.application/src/main/webapp/WEB-INF/scripts/mariadb/init.sql

Updating Olympus and JSR 309 connector versions used on build. Issue #…

146f8f6

…1945.

Fix for downloading MP4 files. Issue #1945.

36f5665

Preliminar structure for video conferencing. Issue #1552.

8dc4506

Fix to correctly obtain the name of the video conference from RCML ve…

af1be9a

…rb. Issue #1552.

Structure for video conferencing attributes. Issue #1552.

4ab645a

Fix for ‘enable’ attribute. Issue #1552.

0070c78

Debug and tests for CAPTION media session parameter. Issue #1552.

1e7fadb

Revert "Debug and tests for CAPTION media session parameter. Issue #1552

7644fb6

." This reverts commit 1e7fadb.

Migration of attribute CAPTION from conference media session to parti…

958ca86

…cipant media session. Issue #1552.

Merge branch 'master' into Issue1552_VideoConferenceRCML

ec07efb

Removing unnecessary XML formatting and adjusting default values for …

9a6c43e

…video conferencing RCMLs. Issue #1552.

Fernando Mendioroz and others added 17 commits October 23, 2017 12:47

PSAP acronym correction

a503b96

updated aws java sdk version with support of adavnce route53 operatio…

c6b420b

…ns, tested s3 upload with this version and its working like a charm

updated domain query to match result even if domain name ends with do…

3be7d87

…t (.)

Addition of http-client configuration parameters for HTTP connection …

f8b817e

…pooling, commented for now as agreed. Issue #2594

Minor comment enhancement. Issue #2594, PR #2595

fa3f270

Critical fix for making Geolocation API work with RC running on MySQL…

3b1b9c5

…. Issue #2596

Merge pull request #2597 from RestComm/Issue2596_GeolocationAPI_MySQL…

0fad039

…_error Critical fix for making Geolocation API work with RC running on MySQL

Issue2598 fix rvd retrieval (#2600)

22436af

build.xml will fetch RVD from github/releases instead of mobicents Refers #2598

Merge pull request #2595 from RestComm/Issue2594_ConnPooling_configur…

43d2e49

…ation Addition of http-client configuration params for HTTP conn pooling

#issue 2603

08ad6d4

added regreg in place of exact https port value

6a509fc

referred #2606

e0d460d

fix

5f5be3a

Comments added.

b1a4dcc

Comments added.

ffc8a30

Merge pull request #2604 from RestComm/isse2603

2ad6813

Remove port for Provider DID URI when SRV enabled.

Merge pull request #2605 from RestComm/sslconfig

8f3f3ac

added regreg in place of exact https port value

jaimecasero reviewed Nov 2, 2017

View reviewed changes

fixed failing tests compilation

26bc4b7

jaimecasero reviewed Nov 2, 2017

View reviewed changes

Hoan HL added 4 commits November 3, 2017 14:37

#2519 ProxyManager not adding proxy part if username has host part in…

4698b02

… register header

gateway component changes: 1. max ttl time to 3600 2. don't add conta…

c8f3aa1

…ct if it's already in 3. adding testcase for proxyManagerTest

github#2519 update code after reviewing PR#2530

d760dd1

github#2519 PR#2530 rebase code

21bd19a

xhoaluu closed this Nov 6, 2017

jaimecasero deleted the issue-2519 branch April 11, 2018 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 2519 #2530

Issue 2519 #2530

xhoaluu commented Sep 29, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 2, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 3, 2017

jaimecasero Nov 2, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 3, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 3, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 3, 2017

jaimecasero Nov 2, 2017

xhoaluu Nov 3, 2017

jaimecasero Nov 3, 2017

Issue 2519 #2530

Issue 2519 #2530

Conversation

xhoaluu commented Sep 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment