fix: switch network button disabled #289
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte (1)
Line range hint
398-433: Add explicit error handling for approval failuresWhile the function has a try-catch block, it doesn't provide specific error handling for common approval scenarios (e.g., user rejection, network issues). This could lead to a poor user experience when transactions fail.
Consider adding specific error handling:
} catch (err) { console.error("Something went wrong while approving ERC20: ", err); + if (String(err).includes("ACTION_REJECTED") || String(err).includes("User rejected")) { + toast.error("Approval cancelled", { + description: "You rejected the transaction", + }); + } else { + toast.error("Approval failed", { + description: err instanceof Error ? err.message : String(err), + }); + } + // Reset approval status + approved = false; } finally {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte(3 hunks)
🧰 Additional context used
📓 Learnings (1)
packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte (2)
Learnt from: MantisClone
PR: RequestNetwork/web-components#141
File: packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte:0-0
Timestamp: 2024-11-12T14:52:33.204Z
Learning: In `packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte`, mapping payment network IDs to their respective approval functions in the `checkApproval` function is acceptable and can improve readability and maintainability.
Learnt from: MantisClone
PR: RequestNetwork/web-components#141
File: packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte:236-247
Timestamp: 2024-11-18T04:03:25.560Z
Learning: In the `checkApproval` function of `packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte` (TypeScript/Svelte code), remember that the `ETH_FEE_PROXY_CONTRACT` payment network ID does not require approval because Ether payments do not need ERC20 approvals.
🔇 Additional comments (1)
packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte (1)
398-398: Consider potential race conditions with transaction signing state
The isSigningTransaction flag is used correctly to prevent multiple simultaneous transactions. However, there could be a race condition if multiple transactions are attempted in quick succession, as the flag might be reset to false before the previous transaction is fully processed.
Consider using a more robust state management solution, such as:
- Using a transaction queue
- Implementing a mutex-like pattern
- Adding a debounce mechanism to the payment buttons
Also applies to: 433-433
…285-switch-network-button-disabled-when-it-should-be-enabled-and-vice-versa
sstefdev
deleted the
285-switch-network-button-disabled-when-it-should-be-enabled-and-vice-versa
branch
Fixes #285
Fixes #287
Problem
Changes
Summary by CodeRabbit
New Features
Bug Fixes