Skip to content

Ab#87614 classic style available for datepicker #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2024
Merged

Ab#87614 classic style available for datepicker #2435

merged 3 commits into from
Mar 7, 2024

Conversation

MwanPygmay
Copy link
Contributor

@MwanPygmay MwanPygmay commented Mar 7, 2024 •
edited
Loading

Description

Add the capacity to use the classic style in the date, datetime and datetime-local components.

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Create a question and go in preview to ensure the style is applied.

Screenshots

image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@MwanPygmay MwanPygmay requested a review from a team March 7, 2024 13:56
@MwanPygmay MwanPygmay self-assigned this Mar 7, 2024
@MwanPygmay MwanPygmay added the enhancement New feature or request label Mar 7, 2024
@AntoineRelief AntoineRelief requested review from AntoineRelief and removed request for a team March 7, 2024 15:35
@AntoineRelief
Merge branch '2.x.x' into AB#87614_classic_style_available_for_datepi…
dc902c1 
…cker # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@AntoineRelief
feat: add calendar type option to date questions
c163d61
@AntoineRelief AntoineRelief merged commit 6518b16 into 2.x.x Mar 7, 2024
@AntoineRelief AntoineRelief deleted the AB#87614_classic_style_available_for_datepicker branch March 7, 2024 16:14
AntoineRelief pushed a commit that referenced this pull request Mar 12, 2024
@semantic-release-bot
chore(release): 2.11.0 [skip ci] # [2.11.0](v2.10.1...v2.11.0) (2024-…
befd871 
…03-12) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json BO resource's subpages not loading fine, and requiring 2x clicks ([#2441](#2441)) ([cc569ce](cc569ce)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json heatmap can now use opacity parameter ([#2439](#2439)) ([80da23e](80da23e)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add calendar type option to date questions ([#2435](#2435)) ([6518b16](6518b16)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow heatmap to have intensity field ([#2437](#2437)) ([027c291](027c291)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json default number of items per page in summary cards now depend by default on height of window ([15072c5](15072c5)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json system now stores selection of page size on summary card widgets, so it can be reused for future widgets ([768ff58](768ff58))
AntoineRelief pushed a commit that referenced this pull request Apr 29, 2024
@semantic-release-bot
chore(release): 2.11.0-beta.1 [skip ci] # [2.11.0-beta.1](v2.10.0...v…
be96bb1 
…2.11.0-beta.1) (2024-04-29) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add correct display of title in chart preview ([#2206](#2206)) ([c1d7c70](c1d7c70)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json automation to hide layers would not work fine ([062151e](062151e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json BO resource's subpages not loading fine, and requiring 2x clicks ([#2441](#2441)) ([cc569ce](cc569ce)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json clicking on points when cluster expand should use lat / long of cluster, not lat / long of click ([#2452](#2452)) ([1317299](1317299)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json dashboard automation service could create dependency injection issues ([#2429](#2429)) ([225ad11](225ad11)), closes [bugfix/AB#87222](https://github.com/bugfix/AB/issues/87222) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json drag & drop would not remove tooltips from the dom ([#2451](#2451)) ([e08c9d7](e08c9d7)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json empty heatmap with valueField could make the map fail ([45bbdbf](45bbdbf)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json filter between pages could sometimes be reactivated ([a76e6fe](a76e6fe)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json heatmap can now use opacity parameter ([#2439](#2439)) ([80da23e](80da23e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json in web elements, some filters could be removed ([5014636](5014636)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json incorrect message error when no access to application ([#2446](#2446)) ([718964f](718964f)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers control would not automatically close when used in web component ([4029ca3](4029ca3)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json onDownloadFile not working when seeing record in form ( display mode ) ([#2453](#2453)) ([06323db](06323db)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json possible conflict between reset filter event and add filter event on widget content click ([e7a48ba](e7a48ba)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json shared-date-filter-menu incorrect date format ([#2230](#2230)) ([86bc965](86bc965)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json some layers could be drawn multiple times due to add layer & remove layer automations ([f20f4ea](f20f4ea)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add calendar type option to date questions ([#2435](#2435)) ([6518b16](6518b16)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow heatmap to have intensity field ([#2437](#2437)) ([027c291](027c291)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json default number of items per page in summary cards now depend by default on height of window ([15072c5](15072c5)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json system now stores selection of page size on summary card widgets, so it can be reused for future widgets ([768ff58](768ff58)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Update Angular packages to v16 ([#2211](#2211)) ([a2ae9e7](a2ae9e7)), closes [#2212](#2212) ### Performance Improvements CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json base case test for ui library ([#2242](#2242)) ([b8ca7ea](b8ca7ea)) ### Reverts CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: add correct display of title in chart preview (#2206)" (#2245) ([b39f3d2](b39f3d2)), closes [#2206](#2206) [#2245](#2245) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: shared-date-filter-menu incorrect date format (#2230)" (#2243) ([6932170](6932170)), closes [#2230](#2230) [#2243](#2243) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "feat: Update Angular packages to v16 (#2211)" (#2222) ([7240f05](7240f05)), closes [#2211](#2211) [#2222](#2222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRelief AntoineRelief Awaiting requested review from AntoineRelief

Assignees

@MwanPygmay MwanPygmay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MwanPygmay @AntoineRelief