Skip to content

Update kendo packages #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented Dec 20, 2023

Description

Updated the kendo packages to the latest versions:

 @progress/kendo-angular-buttons            11  →       14
 @progress/kendo-angular-common             11  →       14
 @progress/kendo-angular-dateinputs         11  →       14
 @progress/kendo-angular-dialog             11  →       14
 @progress/kendo-angular-dropdowns          11  →       14
 @progress/kendo-angular-excel-export       11  →       14
 @progress/kendo-angular-grid               11  →       14
 @progress/kendo-angular-icons              11  →       14
 @progress/kendo-angular-indicators         11  →       14
 @progress/kendo-angular-inputs             11  →       14
 @progress/kendo-angular-intl               11  →       14
 @progress/kendo-angular-l10n               11  →       14
 @progress/kendo-angular-label              11  →       14
 @progress/kendo-angular-layout             11  →       14
 @progress/kendo-angular-listbox            11  →       14
 @progress/kendo-angular-pager              11  →       14
 @progress/kendo-angular-pdf-export         11  →       14
 @progress/kendo-angular-popup              11  →       14
 @progress/kendo-angular-progressbar        11  →       14
 @progress/kendo-angular-treeview           11  →       14
 @progress/kendo-angular-upload             11  →       14
 @progress/kendo-data-query             ^1.6.0  →   ^1.7.0
 @progress/kendo-drawing               ^1.17.3  →  ^1.19.0
 @progress/kendo-licensing              ^1.3.0  →   ^1.3.5
 @progress/kendo-theme-default           6.6.0  →    7.0.2

Updated the kendo icons used in kendo buttons

Kendo icons warning message after update Starting from v7.0.0 (October, 2023) of the Kendo Themes, the font icons will be removed from the theme. * To render an SVG icon, update the component configuration by setting the "svgIcon" input to the respective icon definition. * To continue to use font icons, install the "@progress/kendo-font-icons" package and import "@progress/kendo-font-icons/dist/index.css". Please note, that font icons are not compatible with a strict Content Security Policy and require the use of the "unsafe-inline" override. For further details, check the following documentation articles:

https://www.telerik.com/kendo-angular-ui/components/icons/icon-settings

https://www.telerik.com/kendo-angular-ui/components/styling/icons/

https://www.telerik.com/kendo-angular-ui/components/styling/svg-icons/

https://www.telerik.com/design-system/docs/foundation/iconography/font-icons/

https://www.telerik.com/design-system/docs/foundation/iconography/icon-list/

The other kendo packages have not undergone changes that need to update something in the code.

Useful links

Type of change

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Testing the components using kendo elements.

Screenshots

Now, with the missing license key we get a warning message when opening components with kendo-grid (like grid widget, Reference data fields grid, Invite users grid, etc)
No valid license
And a watermark in the grid:
watermark

Kendo icons warnings before code update after kendo-angular-icons package update:
grid-kendo-icons.webm

After:
after.webm

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement New feature or request label Dec 20, 2023
@estelafs estelafs self-assigned this Dec 21, 2023
@AntoineRelief AntoineRelief added dependencies Pull requests that update a dependency file in code review Under review labels Dec 21, 2023
@estelafs estelafs marked this pull request as ready for review December 21, 2023 16:53
@estelafs estelafs requested a review from a team December 21, 2023 16:53
@unai-reliefapp
Copy link
Contributor

unai-reliefapp commented Dec 22, 2023

All kendo content also correctly displayed in web components 👍
Only thing that on trying to open some dropdowns in the grid filters those are not working(calendar for example)
I'll push a fix for that

@AntoineRelief AntoineRelief changed the base branch from beta to feat/angular-update-from-15v-to-16v December 22, 2023 08:58
@AntoineRelief AntoineRelief merged commit 2241f8b into feat/angular-update-from-15v-to-16v Dec 22, 2023
@AntoineRelief AntoineRelief deleted the feat/kendo-packages-update branch December 22, 2023 09:15
AntoineRelief added a commit that referenced this pull request Dec 22, 2023
* feat: Update kendo packages  to v14 (#2212)

---------

Co-authored-by: Antoine Hurard <antoine.reliefapps@gmail.com>

---------

Co-authored-by: Antoine Hurard <antoine.reliefapps@gmail.com>
Co-authored-by: Estela Ferreira <estelafersil@gmail.com>
AntoineRelief pushed a commit that referenced this pull request Apr 29, 2024
…2.11.0-beta.1) (2024-04-29) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add correct display of title in chart preview ([#2206](#2206)) ([c1d7c70](c1d7c70)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json automation to hide layers would not work fine ([062151e](062151e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json BO resource's subpages not loading fine, and requiring 2x clicks ([#2441](#2441)) ([cc569ce](cc569ce)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json clicking on points when cluster expand should use lat / long of cluster, not lat / long of click ([#2452](#2452)) ([1317299](1317299)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json dashboard automation service could create dependency injection issues ([#2429](#2429)) ([225ad11](225ad11)), closes [bugfix/AB#87222](https://github.com/bugfix/AB/issues/87222) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json drag & drop would not remove tooltips from the dom ([#2451](#2451)) ([e08c9d7](e08c9d7)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json empty heatmap with valueField could make the map fail ([45bbdbf](45bbdbf)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json filter between pages could sometimes be reactivated ([a76e6fe](a76e6fe)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json heatmap can now use opacity parameter ([#2439](#2439)) ([80da23e](80da23e)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json in web elements, some filters could be removed ([5014636](5014636)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json incorrect message error when no access to application ([#2446](#2446)) ([718964f](718964f)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers control would not automatically close when used in web component ([4029ca3](4029ca3)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json onDownloadFile not working when seeing record in form ( display mode ) ([#2453](#2453)) ([06323db](06323db)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json possible conflict between reset filter event and add filter event on widget content click ([e7a48ba](e7a48ba)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json shared-date-filter-menu incorrect date format ([#2230](#2230)) ([86bc965](86bc965)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json some layers could be drawn multiple times due to add layer & remove layer automations ([f20f4ea](f20f4ea)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json add calendar type option to date questions ([#2435](#2435)) ([6518b16](6518b16)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow heatmap to have intensity field ([#2437](#2437)) ([027c291](027c291)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json default number of items per page in summary cards now depend by default on height of window ([15072c5](15072c5)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json system now stores selection of page size on summary card widgets, so it can be reused for future widgets ([768ff58](768ff58)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Update Angular packages to v16 ([#2211](#2211)) ([a2ae9e7](a2ae9e7)), closes [#2212](#2212) ### Performance Improvements CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json base case test for ui library ([#2242](#2242)) ([b8ca7ea](b8ca7ea)) ### Reverts CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: add correct display of title in chart preview (#2206)" (#2245) ([b39f3d2](b39f3d2)), closes [#2206](#2206) [#2245](#2245) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "fix: shared-date-filter-menu incorrect date format (#2230)" (#2243) ([6932170](6932170)), closes [#2230](#2230) [#2243](#2243) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json Revert "feat: Update Angular packages to v16 (#2211)" (#2222) ([7240f05](7240f05)), closes [#2211](#2211) [#2222](#2222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request in code review Under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants