bugfix/AB#87069_SUI-map-unable-close-full-screen-of-map-on-click-of-expand-icon-on-map-widget #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpand-icon-on-map-widget feat: add first version of custom fullscreen control for leaflet map
21 tasks
…xpand-icon-on-map-widget feat: add translations for title property in the new custom leaflet fullscreen control
…xpand-icon-on-map-widget feat: missing listener clean up for custom leaflet fullscreen control
…xpand-icon-on-map-widget fix: property names for clearer ones
|
@AntoineRelief I add some new translations but are not set when using the translate instante. Otherwise this new fullscreen control works as expected for both web component and app builder |
|
@unai-reliefapp as long as you're able to add them in the translation files, I'll deploy them later and it should work |
…xpand-icon-on-map-widget fix: delete console logs
PR ready then 👍 |
…xpand-icon-on-map-widget fix: hardcoded title
unai-reliefapp
commented
Mar 1, 2024
| 'components.map.controls.fullScreen.exitFullscreen' | ||
| ); | ||
| this.fullscreenControl.onAdd = () => { | ||
| const mapContainer = map.getContainer(); |
There was a problem hiding this comment.
Suggested change
| const mapContainer = map.getContainer(); | |
| const mapContainer = map.getContainer()?.parentElement; |
@AntoineRelief
This would fix the first part of this one: #2422 (comment) and fullscreen would still work fine
AntoineRelief
deleted the
bugfix/AB#87069_SUI-map-unable-close-full-screen-of-map-on-click-of-expand-icon-on-map-widget
branch
AntoineRelief
pushed a commit
that referenced
this pull request
Mar 1, 2024
…3-01) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json due to query params some components could be duplicated in sui ([faf3986](faf3986)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json fullscreen control would not work in web elements mode ([#2425](#2425)) ([4f0dd92](4f0dd92)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers overlay could be hidden on maps, when using fullscreen & web elements ([#2424](#2424)) ([49e6db7](49e6db7)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json map could sometimes disappear on some browsers due to a browser limitation ([79d1a1c](79d1a1c)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json only one mutation instance supported ([#2419](#2419)) ([2b80a9f](2b80a9f)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json selecting some reference data in questions in dashboard filter, using web elements, could not reflect on other pages ([#2420](#2420)) ([729957a](729957a)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow widgets to build automation rules ([#2422](#2422)) ([9457fd4](9457fd4))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please refer to videos below
Screenshots
On web component
Compartir.pantalla.-.2024-03-01.13_00_10.mp4
On App Builder:
https://github.com/ReliefApplications/ems-frontend/assets/123092672/24ca420b-8975-4226-b9b1-0408dcb204c4
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145