Skip to content

bugfix/AB#86936_ABC-sometimes-it-becomes-impossible-to-click-the-layers-button-in-the-dashboard #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

bugfix/AB#86936_ABC-sometimes-it-becomes-impossible-to-click-the-layers-button-in-the-dashboard #2424

merged 1 commit into from
Mar 1, 2024

Conversation

unai-reliefapp
Copy link
Contributor

@unai-reliefapp unai-reliefapp commented Mar 1, 2024 •
edited
Loading

Description

  • refactor: use shadow dom service with the overlay container class in order to avoid unnecessary calculation on overlay container addition, as we have the needed dom node in the shadow dom service
  • feat: add overlay container set for shadow root full screen mode if exists

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please refer to video below

Screenshots

Compartir.pantalla.-.2024-03-01.10_33_58.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@unai-reliefapp
bugfix/AB#86936_ABC-sometimes-it-becomes-impossible-to-click-the-laye…
281a52e 
…rs-button-in-the-dashboard refactor: use shadow dom service with the overlay container class in order to avoid unnecessary calculation on overlay container addition, as we have the needed dom node in the shadow dom service feat: add overlay container set for shadow root full screen mode if exists
@unai-reliefapp unai-reliefapp added the bug Something isn't working label Mar 1, 2024
@unai-reliefapp unai-reliefapp self-assigned this Mar 1, 2024
@AntoineRelief AntoineRelief merged commit 49e6db7 into 2.x.x Mar 1, 2024
@AntoineRelief AntoineRelief deleted the bugfix/AB#86936_ABC-sometimes-it-becomes-impossible-to-click-the-layers-button-in-the-dashboard branch March 1, 2024 09:48
AntoineRelief pushed a commit that referenced this pull request Mar 1, 2024
@semantic-release-bot
chore(release): 2.10.0 [skip ci] # [2.10.0](v2.9.0...v2.10.0) (2024-0…
a63ece7 
…3-01) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json due to query params some components could be duplicated in sui ([faf3986](faf3986)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json fullscreen control would not work in web elements mode ([#2425](#2425)) ([4f0dd92](4f0dd92)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json layers overlay could be hidden on maps, when using fullscreen & web elements ([#2424](#2424)) ([49e6db7](49e6db7)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json map could sometimes disappear on some browsers due to a browser limitation ([79d1a1c](79d1a1c)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json only one mutation instance supported ([#2419](#2419)) ([2b80a9f](2b80a9f)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json selecting some reference data in questions in dashboard filter, using web elements, could not reflect on other pages ([#2420](#2420)) ([729957a](729957a)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json allow widgets to build automation rules ([#2422](#2422)) ([9457fd4](9457fd4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenzoPrats RenzoPrats Awaiting requested review from RenzoPrats

@AntoineRelief AntoineRelief Awaiting requested review from AntoineRelief

Assignees

@unai-reliefapp unai-reliefapp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unai-reliefapp @AntoineRelief