Skip to content

Fix 'all' preset, closes #1260 #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

Fix 'all' preset, closes #1260 #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/react-dom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"react-dom": "^19.2.0"
},
"devDependencies": {
"@eslint-react/eslint-plugin": "2.0.4",
"@eslint-react/eslint-plugin": "workspace:*",
"@eslint/config-inspector": "^1.3.0",
"@eslint/js": "^9.36.0",
"@tsconfig/node22": "^22.0.2",
Expand Down
19 changes: 19 additions & 0 deletions packages/plugins/eslint-plugin-react-x/src/configs/recommended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ export const name = "react-x/recommended";
export const rules = {
"react-x/jsx-no-comment-textnodes": "warn",
"react-x/jsx-no-duplicate-props": "warn",
"react-x/jsx-no-iife": "off",
"react-x/jsx-no-undef": "off",
"react-x/jsx-shorthand-boolean": "off",
"react-x/jsx-shorthand-fragment": "off",
"react-x/jsx-uses-react": "warn",
"react-x/jsx-uses-vars": "warn",
"react-x/no-access-state-in-setstate": "error",
Expand All @@ -14,7 +18,9 @@ export const rules = {
"react-x/no-children-for-each": "warn",
"react-x/no-children-map": "warn",
"react-x/no-children-only": "warn",
"react-x/no-children-prop": "off",
"react-x/no-children-to-array": "warn",
"react-x/no-class-component": "off",
"react-x/no-clone-element": "warn",
"react-x/no-component-will-mount": "error",
"react-x/no-component-will-receive-props": "error",
Expand All @@ -24,9 +30,14 @@ export const rules = {
"react-x/no-default-props": "error",
"react-x/no-direct-mutation-state": "error",
"react-x/no-duplicate-key": "error",
"react-x/no-forbidden-props": "off",
"react-x/no-forward-ref": "warn",
"react-x/no-implicit-key": "warn",
"react-x/no-leaked-conditional-rendering": "off",
"react-x/no-missing-component-display-name": "off",
"react-x/no-missing-context-display-name": "off",
"react-x/no-missing-key": "error",
"react-x/no-misused-capture-owner-stack": "off",
"react-x/no-nested-component-definitions": "error",
"react-x/no-nested-lazy-component-declarations": "error",
"react-x/no-prop-types": "error",
Expand All @@ -35,16 +46,24 @@ export const rules = {
"react-x/no-set-state-in-component-did-update": "warn",
"react-x/no-set-state-in-component-will-update": "warn",
"react-x/no-string-refs": "error",
"react-x/no-unnecessary-key": "off",
"react-x/no-unnecessary-use-callback": "off",
"react-x/no-unnecessary-use-memo": "off",
"react-x/no-unnecessary-use-prefix": "warn",
"react-x/no-unsafe-component-will-mount": "warn",
"react-x/no-unsafe-component-will-receive-props": "warn",
"react-x/no-unsafe-component-will-update": "warn",
"react-x/no-unstable-context-value": "warn",
"react-x/no-unstable-default-props": "warn",
"react-x/no-unused-class-component-members": "warn",
"react-x/no-unused-props": "off",
"react-x/no-unused-state": "warn",
"react-x/no-use-context": "warn",
"react-x/no-useless-forward-ref": "warn",
"react-x/no-useless-fragment": "off",
"react-x/prefer-destructuring-assignment": "off",
"react-x/prefer-namespace-import": "off",
"react-x/prefer-read-only-props": "off",
"react-x/prefer-use-state-lazy-initialization": "warn",
} as const satisfies Record<string, RuleConfig>;

Expand Down
4 changes: 2 additions & 2 deletions packages/plugins/eslint-plugin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ export default defineConfig([

Contributions are welcome!

Please follow our [contributing guidelines](https://github.com/Rel1cx/eslint-react/tree/main/.github/CONTRIBUTING.md).
Please follow our [contributing guidelines](https://github.com/Rel1cx/eslint-react/tree/fix-presets/.github/CONTRIBUTING.md).

## License

This project is licensed under the MIT License - see the [LICENSE](https://github.com/Rel1cx/eslint-react/tree/main/LICENSE) file for details.
This project is licensed under the MIT License - see the [LICENSE](https://github.com/Rel1cx/eslint-react/tree/fix-presets/LICENSE) file for details.
21 changes: 11 additions & 10 deletions packages/plugins/eslint-plugin/src/configs/all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export const rules = {
"@eslint-react/jsx-shorthand-fragment": "warn",
"@eslint-react/jsx-uses-react": "warn",
"@eslint-react/jsx-uses-vars": "warn",

"@eslint-react/no-access-state-in-setstate": "error",
"@eslint-react/no-array-index-key": "warn",
"@eslint-react/no-children-count": "warn",
Expand All @@ -38,9 +37,10 @@ export const rules = {
"@eslint-react/no-default-props": "error",
"@eslint-react/no-direct-mutation-state": "error",
"@eslint-react/no-duplicate-key": "error",
"@eslint-react/no-forbidden-props": "off",
"@eslint-react/no-forward-ref": "warn",
"@eslint-react/no-implicit-key": "warn",
// "@eslint-react/no-leaked-conditional-rendering": "warn",
"@eslint-react/no-leaked-conditional-rendering": "off",
"@eslint-react/no-missing-component-display-name": "warn",
"@eslint-react/no-missing-context-display-name": "warn",
"@eslint-react/no-missing-key": "error",
Expand All @@ -63,19 +63,16 @@ export const rules = {
"@eslint-react/no-unstable-context-value": "warn",
"@eslint-react/no-unstable-default-props": "warn",
"@eslint-react/no-unused-class-component-members": "warn",
// "@eslint-react/no-unused-props": "warn",
"@eslint-react/no-unused-props": "off",
"@eslint-react/no-unused-state": "warn",
"@eslint-react/no-use-context": "warn",
"@eslint-react/no-useless-forward-ref": "warn",
"@eslint-react/no-useless-fragment": "warn",
"@eslint-react/prefer-destructuring-assignment": "warn",
"@eslint-react/prefer-namespace-import": "warn",
// "@eslint-react/prefer-read-only-props": "error",
"@eslint-react/prefer-read-only-props": "off",
"@eslint-react/prefer-use-state-lazy-initialization": "warn",

"@eslint-react/hooks-extra/no-direct-set-state-in-use-effect": "warn",
"@eslint-react/hooks-extra/no-direct-set-state-in-use-layout-effect": "warn",

"@eslint-react/dom/no-dangerously-set-innerhtml": "warn",
"@eslint-react/dom/no-dangerously-set-innerhtml-with-children": "error",
"@eslint-react/dom/no-find-dom-node": "error",
Expand All @@ -87,21 +84,25 @@ export const rules = {
"@eslint-react/dom/no-render": "error",
"@eslint-react/dom/no-render-return-value": "error",
"@eslint-react/dom/no-script-url": "warn",
"@eslint-react/dom/no-string-style-prop": "error",
"@eslint-react/dom/no-unknown-property": "warn",
"@eslint-react/dom/no-unsafe-iframe-sandbox": "warn",
"@eslint-react/dom/no-unsafe-target-blank": "warn",
"@eslint-react/dom/no-use-form-state": "error",
"@eslint-react/dom/no-use-form-state": "warn",
"@eslint-react/dom/no-void-elements-with-children": "error",
"@eslint-react/dom/prefer-namespace-import": "warn",

"@eslint-react/web-api/no-leaked-event-listener": "warn",
"@eslint-react/web-api/no-leaked-interval": "warn",
"@eslint-react/web-api/no-leaked-resize-observer": "warn",
"@eslint-react/web-api/no-leaked-timeout": "warn",

"@eslint-react/hooks-extra/no-direct-set-state-in-use-effect": "warn",

"@eslint-react/naming-convention/component-name": "warn",
"@eslint-react/naming-convention/context-name": "warn",
"@eslint-react/naming-convention/filename": "warn",
"@eslint-react/naming-convention/filename-extension": "warn",
"@eslint-react/naming-convention/filename": "off",
"@eslint-react/naming-convention/filename-extension": "off",
"@eslint-react/naming-convention/use-state": "warn",
} as const satisfies Record<string, RuleConfig>;

Expand Down
1 change: 0 additions & 1 deletion packages/plugins/eslint-plugin/src/configs/recommended-type-checked.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export const rules = {
...recommendedTypeScript.rules,
"@eslint-react/no-leaked-conditional-rendering": "warn",
"@eslint-react/no-unused-props": "warn",
// "@eslint-react/prefer-read-only-props": "warn",
} as const satisfies Record<string, RuleConfig>;

export const plugins = {
Expand Down
37 changes: 19 additions & 18 deletions packages/plugins/eslint-plugin/src/configs/x.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,21 @@ export const name = "@eslint-react/x";
export const rules = {
"@eslint-react/jsx-no-comment-textnodes": "warn",
"@eslint-react/jsx-no-duplicate-props": "warn",
// "@eslint-react/jsx-no-iife": "warn",
// "@eslint-react/jsx-no-undef": "error",
// "@eslint-react/jsx-shorthand-boolean": "warn",
// "@eslint-react/jsx-shorthand-fragment": "warn",
"@eslint-react/jsx-no-iife": "off",
"@eslint-react/jsx-no-undef": "off",
"@eslint-react/jsx-shorthand-boolean": "off",
"@eslint-react/jsx-shorthand-fragment": "off",
"@eslint-react/jsx-uses-react": "warn",
"@eslint-react/jsx-uses-vars": "warn",

"@eslint-react/no-access-state-in-setstate": "error",
"@eslint-react/no-array-index-key": "warn",
"@eslint-react/no-children-count": "warn",
"@eslint-react/no-children-for-each": "warn",
"@eslint-react/no-children-map": "warn",
"@eslint-react/no-children-only": "warn",
// "@eslint-react/no-children-prop": "warn",
"@eslint-react/no-children-prop": "off",
"@eslint-react/no-children-to-array": "warn",
// "@eslint-react/no-class-component": "warn",
"@eslint-react/no-class-component": "off",
"@eslint-react/no-clone-element": "warn",
"@eslint-react/no-component-will-mount": "error",
"@eslint-react/no-component-will-receive-props": "error",
Expand All @@ -32,13 +31,14 @@ export const rules = {
"@eslint-react/no-default-props": "error",
"@eslint-react/no-direct-mutation-state": "error",
"@eslint-react/no-duplicate-key": "error",
"@eslint-react/no-forbidden-props": "off",
"@eslint-react/no-forward-ref": "warn",
"@eslint-react/no-implicit-key": "warn",
// "@eslint-react/no-leaked-conditional-rendering": "warn",
// "@eslint-react/no-missing-component-display-name": "warn",
// "@eslint-react/no-missing-context-display-name": "warn",
"@eslint-react/no-leaked-conditional-rendering": "off",
"@eslint-react/no-missing-component-display-name": "off",
"@eslint-react/no-missing-context-display-name": "off",
"@eslint-react/no-missing-key": "error",
// "@eslint-react/no-misused-capture-owner-stack": "error",
"@eslint-react/no-misused-capture-owner-stack": "off",
"@eslint-react/no-nested-component-definitions": "error",
"@eslint-react/no-nested-lazy-component-declarations": "error",
"@eslint-react/no-prop-types": "error",
Expand All @@ -47,23 +47,24 @@ export const rules = {
"@eslint-react/no-set-state-in-component-did-update": "warn",
"@eslint-react/no-set-state-in-component-will-update": "warn",
"@eslint-react/no-string-refs": "error",
// "@eslint-react/no-unnecessary-use-callback": "warn",
// "@eslint-react/no-unnecessary-use-memo": "warn",
"@eslint-react/no-unnecessary-key": "off",
"@eslint-react/no-unnecessary-use-callback": "off",
"@eslint-react/no-unnecessary-use-memo": "off",
"@eslint-react/no-unnecessary-use-prefix": "warn",
"@eslint-react/no-unsafe-component-will-mount": "warn",
"@eslint-react/no-unsafe-component-will-receive-props": "warn",
"@eslint-react/no-unsafe-component-will-update": "warn",
"@eslint-react/no-unstable-context-value": "warn",
"@eslint-react/no-unstable-default-props": "warn",
"@eslint-react/no-unused-class-component-members": "warn",
// "@eslint-react/no-unused-props": "warn",
"@eslint-react/no-unused-props": "off",
"@eslint-react/no-unused-state": "warn",
"@eslint-react/no-use-context": "warn",
"@eslint-react/no-useless-forward-ref": "warn",
// "@eslint-react/no-useless-fragment": "warn",
// "@eslint-react/prefer-destructuring-assignment": "warn",
// "@eslint-react/prefer-namespace-import": "warn",
// "@eslint-react/prefer-read-only-props": "error",
"@eslint-react/no-useless-fragment": "off",
"@eslint-react/prefer-destructuring-assignment": "off",
"@eslint-react/prefer-namespace-import": "off",
"@eslint-react/prefer-read-only-props": "off",
"@eslint-react/prefer-use-state-lazy-initialization": "warn",
} as const satisfies Record<string, RuleConfig>;

Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.