Skip to content

Conversation

@Rel1cx
Copy link
Owner

@Rel1cx Rel1cx commented Oct 3, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Test
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
eslint-react Ready Ready Preview Comment Oct 3, 2025 0:22am

@Rel1cx Rel1cx marked this pull request as ready for review October 3, 2025 00:17
@Rel1cx Rel1cx requested a review from Copilot October 3, 2025 00:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the 'all' preset configuration for eslint-react by ensuring all available rules are explicitly included and properly configured. The changes address issue #1260 by converting commented-out rules to explicit "off" configurations and reorganizing rule definitions.

Key changes:

  • Convert commented-out rules to explicit "off" configurations in all config presets
  • Add missing rules to the 'all' preset configuration
  • Update example configurations and package references

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/plugins/eslint-plugin/src/configs/x.ts Convert commented rules to explicit "off" settings and add missing rule
packages/plugins/eslint-plugin/src/configs/recommended-type-checked.ts Remove commented rule line
packages/plugins/eslint-plugin/src/configs/all.ts Add missing rules, reorganize structure, and convert commented rules to explicit settings
packages/plugins/eslint-plugin/README.md Update documentation links to use fix-presets branch
packages/plugins/eslint-plugin-react-x/src/configs/recommended.ts Add missing rules with "off" configuration
examples/react-dom/package.json Update dependency to use workspace reference
examples/react-dom/eslint.config.js Change config from recommended-type-checked to disable-type-checked
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants