add path for TRTRZ and UNMRZ in ILAENV#1325
Open
langou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes #1289
In #1289, @jschueller introduced dedicated paths for CTZRZF (NB2) and CUNMRZ (NB4) in GELSY
INFO = 0 NB1 = ILAENV( 1, 'CGEQRF', ' ', M, N, -1, -1 ) - NB2 = ILAENV( 1, 'CGERQF', ' ', M, N, -1, -1 ) + NB2 = ILAENV( 1, 'CTZRZF', ' ', M, N, -1, -1 ) NB3 = ILAENV( 1, 'CUNMQR', ' ', M, N, NRHS, -1 ) - NB4 = ILAENV( 1, 'CUNMRQ', ' ', M, N, NRHS, -1 ) + NB4 = ILAENV( 1, 'CUNMRZ', ' ', M, N, NRHS, -1 ) NB = MAX( NB1, NB2, NB3, NB4 ) LWKOPT = MAX( 1, MN+2*N+NB*(N+1), 2*MN+NB*NRHS ) WORK( 1 ) = CMPLX( LWKOPT )But, as pointed out by @martin-frbg, #1289 (comment), these paths did not exist in ILAENV. So then ILAENV was returning the default value of NB2 = 1 and NB4 = 1.
We might accept the previous code (before PR #1289) as saying "the optimal block size for TZRZF is the same as the block size for GERQF", so we do not need to create a dedicated path for TZRZF in ILAENV, we simply call ILAENV with argument GERQF.
This commits keeps the PR as is and adds the two paths to ILAENV.
Note: It might feel "lazy" to drop the paths at the start like this. But I think it is better than hide the paths in a series of nested IFs. They are cons and pros to the nested IFs. I chose to drop it at the top.