gelsy: fix ILAENV workspace query routines for TZRZF/UNMRZ#1289
Merged
Conversation
The workspace NB queries in all four ?gelsy variants used ?GERQF and ?UNMRQ, but the routines actually called at runtime are ?TZRZF and ?UNMRZ (real) / ?UNMRZ (complex). While ?GERQF and ?TZRZF are related (both produce an RQ-like factorization), their block sizes may differ in ILAENV's tuned values. If the user relied on LWKOPT from the query to allocate exactly the right workspace, the actual ?TZRZF/?UNMRZ calls could underflow or overflow the work array. Fix the ILAENV calls to match the routines actually invoked: ?GERQF -> ?TZRZF ?UNMRQ -> ?UNMRZ Closes Reference-LAPACK#676
martin-frbg
approved these changes
Jun 11, 2026
langou
approved these changes
Jun 12, 2026
Collaborator
|
Getting belated qualms here - it appears the "wrong" routines may have been used here precisely because ILAENV has no matching configuration for any |
Contributor
@martin-frbg: you are correct. See #1325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace NB queries in all four ?gelsy variants used ?GERQF and ?UNMRQ, but the routines actually called at runtime are ?TZRZF and ?UNMRZ (real) / ?UNMRZ (complex).
While ?GERQF and ?TZRZF are related (both produce an RQ-like factorization), their block sizes may differ in ILAENV's tuned values. If the user relied on LWKOPT from the query to allocate exactly the right workspace, the actual ?TZRZF/?UNMRZ calls could underflow or overflow the work array.
Fix the ILAENV calls to match the routines actually invoked:
?GERQF -> ?TZRZF
?UNMRQ -> ?UNMRZ
Closes #676