Skip to content

refactor: broaden container settings args #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

refactor: broaden container settings args #390

wants to merge 16 commits into from

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Sep 6, 2025 •
edited
Loading

PR 2/2 split from #329. This is a continuation of #387. We break the signature of run_container_* and prepare_volume to introduce the more generic ProcessedContainerSettings parameter, which helps pass more options to container frameworks.

This will be used for dsub testing, and also happens to be used in #329 to avoid the algorithm-container dependency diamond.

This also moves enable_profiling into containers. This was an oversight from my part which I missed in the #387 merge.

@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 6, 2025 •
edited
Loading

Documentation build overview

📚 spras | 🛠️ Build #30171350 | 📁 Comparing 50d7b50 against latest (c3b02cd)


🔍 Preview build

Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
fordevs/spras.analysis.html 📝 modified
fordevs/spras.config.html 📝 modified
fordevs/spras.html 📝 modified

@tristan-f-r tristan-f-r mentioned this pull request Sep 6, 2025
Open
6 tasks
@tristan-f-r tristan-f-r added refactor Changes that don't actually improve anything except for code quality. blocked-by-other-pr labels Sep 6, 2025
@tristan-f-r tristan-f-r mentioned this pull request Sep 6, 2025
Merged
@tristan-f-r tristan-f-r changed the title refactor: pass around container settings refactor: broaden container settings args Sep 21, 2025
@tristan-f-r tristan-f-r added the P-medium medium prirotity; this is needed for some external service or another PR label Sep 25, 2025
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Oct 3, 2025
@tristan-f-r tristan-f-r added the tuning Workflow-spanning algorithm tuning label Oct 14, 2025
@tristan-f-r
Copy link
Collaborator Author

This has been tagged with tuning because it is a dependency of #321.

@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Oct 24, 2025
agitter
agitter reviewed Oct 31, 2025
View reviewed changes
@tristan-f-r tristan-f-r added P-high This is a blocker for many PRs/issues/features and removed P-medium medium prirotity; this is needed for some external service or another PR labels Nov 1, 2025
agitter
agitter reviewed Nov 1, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agitter agitter agitter left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

P-high This is a blocker for many PRs/issues/features refactor Changes that don't actually improve anything except for code quality. tuning Workflow-spanning algorithm tuning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tristan-f-r @agitter