- 
                Notifications
    
You must be signed in to change notification settings  - Fork 24
 
feat!: typed PRA#run #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            tristan-f-r
  wants to merge
  72
  commits into
  Reed-CompBio:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
tristan-f-r:config-args
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            feat!: typed PRA#run #329
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    bad merge conflict resolution
              
                    ntalluri
  
              
              reviewed
              
                  
                    Oct 28, 2025 
                  
              
              
            
            
| 
           If this gets pushed in, should the documentation for the   | 
    
              
                    ntalluri
  
              
              reviewed
              
                  
                    Oct 28, 2025 
                  
              
              
            
            
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
              
                    ntalluri
  
              
              reviewed
              
                  
                    Oct 28, 2025 
                  
              
              
            
            
bad copy & paste
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    blocked-by-other-pr
  
    enhancement
  New feature or request 
  
    needed for benchmarking
  Priority PRs needed for the benchmarking paper 
  
    P-high
  This is a blocker for many PRs/issues/features 
  
    tuning
  Workflow-spanning algorithm tuning 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Note
This also contains changes that close #297 to resolve a dependency diamond. I was debating about splitting that to another PR, but that 'containers' PR would depend on #292 (giving this 2 degrees of dependency), and the types in PRA#run actually make that change easier to follow and motivate.
containerskey #387This also borrows (not a direct dependency) from #286. #286 should be merged after #329 is merged, as there's a good chance that we can just auto-generate documentation from the documentation here instead.
Closes #321, closes #296, and closes #297.
Arguments are now specified as a pydantic BaseModel with attached documentation:
When constructing a
PRM, this is passed in as a generic:For algorithms that don't specify parameters, the
Emptytype is preferred instead (whose signature is the emptyBaseModelwith an attachedmodel_configthat doesn't allow any other parameters.This also changes the signature of
PRA#run(reflecting the PR title) to be:This has the disadvantage that
inputsno longer has code completion, but this was probably something to not hide from the developer-user anyway, as we were passing inputs in via kwargs. See:All of this gives us:
Typed Implementation Details
pathlibthroughout.For reviewers
algorithms.pyis the only "dense code" in this PR. Otherwise, most of this is just refactoring all of thePRA#runcalls to meet the new signature, specifying the new parameter models, and applying the suggestions in #296 (only in this PR) and #297 (see #387 and #390).