Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join command failing on null values with --prefix-components-with-info-prop option #1444

Merged
merged 8 commits into from
Feb 19, 2024
Merged

fix: join command failing on null values with --prefix-components-with-info-prop option #1444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16812ec
fix: join command failing on null values with --prefix-components-wit…
tatomyr Feb 19, 2024
8987f60
refactor split and add a test
tatomyr Feb 19, 2024
78c0100
cleanup imports
tatomyr Feb 19, 2024
d2516fd
remove export in join
tatomyr Feb 19, 2024
7b4a147
fix test
tatomyr Feb 19, 2024
798fdf9
add the changeset
tatomyr Feb 19, 2024
0539ee9
Update .changeset/spotty-pets-doubt.md
tatomyr Feb 19, 2024
ddc3e2b
move visitor out of the loop
tatomyr Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup imports
  • Loading branch information
@tatomyr
tatomyr committed Feb 19, 2024
commit 78c0100d435f5cc820097682e88a435c0959b4b1
3 changes: 1 addition & 2 deletions packages/cli/src/commands/join.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
bundleDocument,
isRef,
} from '@redocly/openapi-core';

import {
getFallbackApisOrExit,
printExecutionTime,
Expand All @@ -30,7 +29,7 @@ import { isObject, isString, keysOf } from '../utils/js-utils';
import { COMPONENTS, OPENAPI3_METHOD } from './split/types';
import { startsWithComponents } from './split';

import { Oas3Definition, Document, Oas3Tag, Referenced, RuleSeverity } from '@redocly/openapi-core';
import type { Oas3Definition, Document, Oas3Tag, Referenced, RuleSeverity } from '@redocly/openapi-core';
import type { BundleResult } from '@redocly/openapi-core/lib/bundle';
import type {
Oas3Parameter,
Expand Down
14 changes: 8 additions & 6 deletions packages/cli/src/commands/split/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import { red, blue, yellow, green } from 'colorette';
import * as fs from 'fs';
import { parseYaml, slash, isRef, isTruthy } from '@redocly/openapi-core';
import type { OasRef } from '@redocly/openapi-core';
import * as path from 'path';
import { performance } from 'perf_hooks';
const isEqual = require('lodash.isequal');

import {
printExecutionTime,
pathToFilename,
Expand All @@ -18,6 +16,14 @@ import {
} from '../../utils/miscellaneous';
import { isObject, isEmptyObject } from '../../utils/js-utils';
import {
OPENAPI3_COMPONENT,
COMPONENTS,
OPENAPI3_METHOD_NAMES,
OPENAPI3_COMPONENT_NAMES,
} from './types';

import type { OasRef } from '@redocly/openapi-core';
import type {
Definition,
Oas2Definition,
Oas3Schema,
Expand All @@ -28,10 +34,6 @@ import {
ComponentsFiles,
RefObject,
Oas3PathItem,
OPENAPI3_COMPONENT,
COMPONENTS,
OPENAPI3_METHOD_NAMES,
OPENAPI3_COMPONENT_NAMES,
Referenced,
} from './types';

Expand Down