fix: join command failing on null values with --prefix-components-with-info-prop option #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ddc3e2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage report
Show files with reduced coverage 🔻
Test suite run success713 tests passing in 101 suites. Report generated by 🧪jest coverage report action from ddc3e2b |
|
tatomyr
force-pushed
the
fix/join-failing-with-prefix-components-with-info-prop
branch
from
40a972c to
d2516fd
Compare
lornajane
reviewed
Feb 19, 2024
Co-authored-by: Lorna Jane Mitchell <github@lornajane.net>
|
@lornajane updated the description. |
IgorKarpiuk
approved these changes
Feb 19, 2024
IgorKarpiuk
approved these changes
Feb 19, 2024
tatomyr
deleted the
fix/join-failing-with-prefix-components-with-info-prop
branch
| .split('/') | ||
| .map((name: string, i: number, arr: []) => { | ||
| .map((name, i, arr) => { | ||
| return arr.length - 1 === i && !name.includes(componentsPrefix) |
There was a problem hiding this comment.
This check would better be !name.startsWith(componentsPrefix) so that if someone coincidentally uses the component prefix somewhere inside the name, the prefix is added nonetheless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Since 1.9.0
joinfails when used with the --prefix-components-with-info-prop option and a schema containsnullvalue.This PR resolves the issue by moving the crawl visitor out of the loop.
Also, did a small refactoring of
splitcommand (reusing shared things withjoin, types correction).Reference
Fixes #1440
Testing
Screenshots (optional)
Has code been changed?
Security