fix: fix for incorrect refs on join

.changeset/grumpy-rings-beam.md

@@ -0,0 +1,5 @@
+---
+"@redocly/cli": patch
+---
+
+Fixed an issue where using the `--prefix-components-with-info-prop` option with the `join` command caused `$refs` to include duplicated prefixes.

__tests__/join/prefix-components-with-info-prop/bar.yaml

@@ -25,3 +25,6 @@ components:
     some-property:
       description: bar description
       type: string
+    another-property:
+      description: description
+      $ref: '#/components/schemas/some-property'

__tests__/join/prefix-components-with-info-prop/foo.yaml

@@ -33,3 +33,6 @@ components:
     some-property:
       description: foo description
       type: string
+    another-property:
+      description: description
+      $ref: '#/components/schemas/some-property'

__tests__/join/prefix-components-with-info-prop/snapshot.js

@@ -55,9 +55,15 @@ components:
     Foo Example OpenAPI 3 definition foo._some-property:
       description: foo description
       type: string
+    Foo Example OpenAPI 3 definition foo._another-property:
+      description: description
+      $ref: '#/components/schemas/Foo Example OpenAPI 3 definition foo._some-property'
     Bar Example OpenAPI 3 definition._some-property:
       description: bar description
       type: string
+    Bar Example OpenAPI 3 definition._another-property:
+      description: description
+      $ref: '#/components/schemas/Bar Example OpenAPI 3 definition._some-property'
 x-tagGroups:
   - name: Foo Example OpenAPI 3 definition foo.
     tags:

packages/cli/src/commands/join.ts

@@ -51,7 +51,7 @@
   apiFilename: string;
   apiTitle?: string;
   tags: Oas3Tag[];
   potentialConflicts: any;
   tagsPrefix: string;
   componentsPrefix: string | undefined;
 };
@@ -183,7 +183,7 @@
     }
   }
 
   const joinedDef: any = {};
   const potentialConflicts = {
     tags: {},
     paths: {},
@@ -306,7 +306,7 @@
   }
 
   function getIndexGroup(name: string): number {
     return joinedDef[xTagGroups].findIndex((item: any) => item.name === name);
   }
 
   function createXTagGroups(name: string) {
@@ -314,7 +314,7 @@
       joinedDef[xTagGroups] = [];
     }
 
     if (!joinedDef[xTagGroups].some((g: any) => g.name === name)) {
       joinedDef[xTagGroups].push({ name, tags: [] });
     }
 
@@ -340,7 +340,7 @@
         joinedDef['servers'] = [];
       }
       for (const server of servers) {
         if (!joinedDef.servers.some((s: any) => s.url === server.url)) {
           joinedDef.servers.push(server);
         }
       }
@@ -639,7 +639,7 @@
   }
 
   function addInfoSectionAndSpecVersion(
     documents: any,
     prefixComponentsWithInfoProp: string | undefined
   ) {
     const firstApi = documents[0];
@@ -801,7 +801,7 @@
 function crawl(object: any, visitor: any) {
   if (!isObject(object)) return;
   for (const key of Object.keys(object)) {
-    visitor(object, key);
+    visitor(object[key], key);
     crawl(object[key], visitor);
   }
 }