Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for incorrect refs on join #1400

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

o-bbk
Copy link
Contributor

@o-bbk o-bbk commented Jan 19, 2024

What/Why/How?

fix for incorrect refs on running join with --prefix-components-with-info-prop prefix

Reference

Closes #1287
Closes #374

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@o-bbk o-bbk requested a review from a team as a code owner January 19, 2024 17:15
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 49de5d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.047 ± 0.011 1.033 1.067 1.01 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.033 ± 0.024 1.004 1.086 1.00

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.1% 4302/5653
🟡 Branches 65.72% 2232/3396
🟡 Functions 68.81% 695/1010
🟡 Lines 76.31% 4045/5301

Test suite run success

699 tests passing in 100 suites.

Report generated by 🧪jest coverage report action from 49de5d4

@o-bbk o-bbk requested a review from a team as a code owner February 6, 2024 15:22
Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Heather Cloward <heathercloward@gmail.com>
@malis42 malis42 merged commit 4a913d6 into main Feb 7, 2024
29 checks passed
@malis42 malis42 deleted the fix/incorrect-refs-on-join branch February 7, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants