Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI infrastructure and dependency management by migrating from deprecated pkg_resources to importlib.metadata, splitting the nightly workflow, and updating various versions across the board.
Key changes:
- Removed deprecated
pkg_resourcesin favor ofimportlib.metadatafor version retrieval - Split nightly CI schedule into a separate workflow file that calls the main CI workflow
- Updated GitHub Actions (checkout@v3→v4, setup-python@v4→v5, cache@v3→v4, codecov@v3→v4) and Poetry (1.5.1→2.2.1)
- Upgraded test matrix to Python 3.11-3.13, Redis 7.4/8.2, and latest Ubuntu/macOS runners
- Updated poetry.lock with newer package versions (distro, exceptiongroup, packaging, psutil, pytest, redis)
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| poetry.lock | Updated lock file for Poetry 2.2.1 with bumped dependency versions and added dependency groups/markers |
| RLTest/_version.py | Replaced deprecated pkg_resources with importlib.metadata for version retrieval |
| .github/workflows/nightly.yml | New workflow file for nightly scheduled builds that calls the main CI workflow |
| .github/workflows/ci.yml | Updated to workflow_call trigger, bumped action versions, updated Python (3.11-3.13) and Redis (7.4/8.2) versions, switched to latest runners |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alonre24
approved these changes
Nov 16, 2025
kei-nan
pushed a commit
to kei-nan/RLTest
that referenced
this pull request
Dec 2, 2025
* split nightly from generic CI * version bump actions * update poetry lock * remove usage of pkg_resources * bump poetry version * update toml and poetry lock again * fix whitespace * Rename nightly-build job to build in biweekly.yml * support version on python 3.7 * run CI on older and newer python version * add old versions back and lock poetry * fix run * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * fix poetry lock * CI improvement * improve comment and concurrency group * add failure notification
kei-nan
pushed a commit
to kei-nan/RLTest
that referenced
this pull request
Dec 2, 2025
* split nightly from generic CI * version bump actions * update poetry lock * remove usage of pkg_resources * bump poetry version * update toml and poetry lock again * fix whitespace * Rename nightly-build job to build in biweekly.yml * support version on python 3.7 * run CI on older and newer python version * add old versions back and lock poetry * fix run * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * fix poetry lock * CI improvement * improve comment and concurrency group * add failure notification
GuyAv46
added a commit
that referenced
this pull request
Dec 8, 2025
* initial commit * Add message and depth parameters to all Query assertions (#237) * add depth and message for Query, and some related fixes * remove unused import * CI update (#238) * split nightly from generic CI * version bump actions * update poetry lock * remove usage of pkg_resources * bump poetry version * update toml and poetry lock again * fix whitespace * Rename nightly-build job to build in biweekly.yml * support version on python 3.7 * run CI on older and newer python version * add old versions back and lock poetry * fix run * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * fix poetry lock * CI improvement * improve comment and concurrency group * add failure notification * Improve waitCluster (#239) * refactor to use cluster slots to ensure agreement * expose to Env * wait for both OK and same topo * minor improvements * print rltest args * code review comments * code review comments * fixes * small fix * remove redundant function call * Apply suggestions from code review Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> --------- Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
pkg_resourceswill not be supported starting 30/11/25macos-13won't be supported soonFull changes:
pkg_resourcestoolmacos-13(about to be removed) runs withmacos-latest