Add message and depth parameters to all Query assertions #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
force-pushed
the
guyav-improvements
branch
from
1e441ff to
b7ade8f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Query class assertion methods by adding message and depth parameters to all Query assertion methods, providing better flexibility for error reporting and stack trace depth control. Additional related fixes improve consistency throughout the codebase.
- Add
messageanddepthparameters to all 10 Query assertion methods (equal, noEqual, true, false, ok, contains, notContains, error, noError) - Fix depth parameter propagation in
assertExistsmethod - Enhance
assertResponseErrorto properly forward message parameter to internal assertions - Clean up code by removing unused import and adding type hint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meiravgri
approved these changes
Nov 16, 2025
kei-nan
pushed a commit
to kei-nan/RLTest
that referenced
this pull request
Dec 2, 2025
…dules#237) * add depth and message for Query, and some related fixes * remove unused import
kei-nan
pushed a commit
to kei-nan/RLTest
that referenced
this pull request
Dec 2, 2025
…dules#237) * add depth and message for Query, and some related fixes * remove unused import
GuyAv46
added a commit
that referenced
this pull request
Dec 8, 2025
* initial commit * Add message and depth parameters to all Query assertions (#237) * add depth and message for Query, and some related fixes * remove unused import * CI update (#238) * split nightly from generic CI * version bump actions * update poetry lock * remove usage of pkg_resources * bump poetry version * update toml and poetry lock again * fix whitespace * Rename nightly-build job to build in biweekly.yml * support version on python 3.7 * run CI on older and newer python version * add old versions back and lock poetry * fix run * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * another attempt * fix poetry lock * CI improvement * improve comment and concurrency group * add failure notification * Improve waitCluster (#239) * refactor to use cluster slots to ensure agreement * expose to Env * wait for both OK and same topo * minor improvements * print rltest args * code review comments * code review comments * fixes * small fix * remove redundant function call * Apply suggestions from code review Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> --------- Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add message and depth parameters to all Query assertions, and some additional related fixes