Add 'desktop_browser' to the list of keys to ignore #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2021 20:57
'backgroundRadius' doesn't work when converting camelCase to underscore, so adding it's parent key of 'desktop_browser' to the ignore list to prevent the conversion
|
Thank you for your two PRs! Version 0.5.2 was published a minute ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'backgroundRadius' doesn't work when converting camelCase to underscore, so adding it's parent key of 'desktop_browser' to the ignore list to prevent the conversion.
the other camelCased keys here ('backgroundColor' and 'imageScale') seem to work either way, so no harm there.
Fixes RealFaviconGenerator/realfavicongenerator#449
Fixes RealFaviconGenerator/realfavicongenerator#458