Skip to content

Update rfg-api to latest #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

matt-koevort
Copy link
Contributor

@matt-koevort matt-koevort commented May 1, 2024

We're hoping this will allow us to use the backgroundColor and backgroundRadius properties under desktopBrowser as it currently does not work. It seems like it was suggested that this was fixed with this PR, which correlated with rfg-api 0.5.2.

@matt-koevort
Copy link
Contributor Author

@phbernard could you take a look at this please. Could you also confirm if it is indeed possible to add background color and radius for the desktop favicon? It works on the UI version of the tool which is what we are hoping for, but no matter what config we use for desktopBrowser, it doesn't work as expected.

@phbernard phbernard merged commit e909111 into RealFaviconGenerator:master May 13, 2024
@phbernard
Copy link
Contributor

Hey @matt-koevort , thank you for contributing! I've just published version 0.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants