Added github issue render UI

[skv93-coder]

Date: 04-12-23

Developer Name: Shubham Sharma

---

Issue Ticket Number

• Render GitHub issue on task request #625

Description

This PR enables the rendering of github issue on the dashboard site

Documentation Updated?

• Yes
• No

If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.

Breaking Changes

• Yes
• No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

• Yes
• No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

• Yes
• No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

• Yes
• No

Specify if the changes are currently under a feature flag.

Database Changes

• Yes
• No

Indicate whether the changes include modifications to the database.

Screenshots

Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.

screen-capture.3.webm

Additional Notes

Discussion on changes in button issue
RealDevSquad/website-backend#1767
#641

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	96ebbd5
Status:	✅  Deploy successful!
Preview URL:	https://7c1cd15d.dashboard-rds.pages.dev
Branch Preview URL:	https://feature-github-issue-render.dashboard-rds.pages.dev

View logs

[Ajeyakrishna-k]

The issue card does not look like the one at status site.

• Different size
• Lot of missing details

[Ajeyakrishna-k]

Still does not look the same as status site issues card.

• Need to add border
• Also add a video of how the page will look on different screen size

A

[Ajeyakrishna-k]

Since the Reject button has been moved beside the requestors here, I had couple of questions:

• Is there an issue created for this change? Can you share the link for the same?
• What happens when there are multiple requestors? Can we reject a task request for a single requestor and approve for others?
• Does the backend api handle rejecting a task request for a single requestor?
• Why are these changes not under a feature flag?

[skv93-coder]

Member

Since the Reject button has been moved beside the requestors here, I had couple of questions:

• Is there an issue created for this change? Can you share the link for the same?
  The changes came up in discussion in discord meeting with tejas
• What happens when there are multiple requestors? Can we reject a task request for a single requestor and approve for others?
  No, for this as we discussed the API is not available
• Does the backend api handle rejecting a task request for a single requestor?
  No, Reject btn need rejection per user website-backend#1767
• Why are these changes not under a feature flag?
  Moving them under feature flag

[Ajeyakrishna-k]

• As per my initial discussions with Ankush we had decided that there is no point in rejecting a task request for a single user request. This is because the request is considered as rejected when someone else's request gets approved.
  PRD :- https://docs.google.com/document/d/1El7k9XrwWIoR3I-7udS-cg0XxVb3InjOU4Cw3qK565g/edit#heading=h.cxpij3s7de98

Is there an issue created for this change? Can you share the link for the same?
The changes came up in discussion in discord meeting with tejas

• Can you please provide a design doc for changing this functionality with approvals from Tejas and Ankush

[Ajeyakrishna-k]

I would recommend handling the Reject Button task in a separate PR.

[skv93-coder]

I would recommend handling the Reject Button task in a separate PR.

Yes, i think the UI and functionality of button requires a lot of discussion so removing them from this PR.

[Ajeyakrishna-k]

Added one comment. Rest everything looks good

[Ajeyakrishna-k]

Is it possible to show the requestors first in mobile view? As you can see from the video it looks very tedious to scroll all the way down and then approve. Especially when the issue is very long.

[skv93-coder]

Is it possible to show the requestors first in mobile view? As you can see from the video it looks very tedious to scroll all the way down and then approve. Especially when the issue is very long.

sure adding the same in next iteration as was not in initial issue but can i get an approval for this