Skip to content

Removes dev flag from fetch task requests #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 3 commits into from
Jan 1, 2024
Merged

Removes dev flag from fetch task requests #1807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee472b
chore: removes dev flag from fetch task requests
Ajeyakrishna-k Dec 22, 2023
a3a2597
Merge branch 'develop' into remove/task-requests-dev-flag
Ajeyakrishna-k Dec 30, 2023
9f05fb7
Merge branch 'develop' into remove/task-requests-dev-flag
Ajeyakrishna-k Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions controllers/tasksRequests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,9 @@ const usersUtils = require("../utils/users");

const fetchTaskRequests = async (_, res) => {
try {
const { dev } = _.query;
let data;
if (dev === "true") {
data = await taskRequestsModel.fetchPaginatedTaskRequests(_.query);
if (data.error) {
return res.status(data.statusCode).json(data);
}
} else {
data = {};
data.data = await taskRequestsModel.fetchTaskRequests(true);
const data = await taskRequestsModel.fetchPaginatedTaskRequests(_.query);
if (data.error) {
return res.status(data.statusCode).json(data);
}

return res.status(200).json({
Expand Down
7 changes: 5 additions & 2 deletions routes/taskRequests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@ const validators = require("../middlewares/validators/task-requests");

router.get("/", authenticate, taskRequests.fetchTaskRequests);
router.get("/:id", authenticate, taskRequests.fetchTaskRequestById);
router.post("/addOrUpdate", authenticate, validateUser, taskRequests.addOrUpdate);
router.patch("/approve", authenticate, authorizeRoles([SUPERUSER]), validateUser, taskRequests.updateTaskRequests);
router.patch("/", authenticate, authorizeRoles([SUPERUSER]), validateUser, taskRequests.updateTaskRequests);
router.post("/", authenticate, validators.postTaskRequests, taskRequests.addTaskRequests);

router.post("/migrations", authenticate, authorizeRoles([SUPERUSER]), taskRequests.migrateTaskRequests);

// Deprecated | @Ajeyakrishna-k | https://github.com/Real-Dev-Squad/website-backend/issues/1597
router.post("/addOrUpdate", authenticate, validateUser, taskRequests.addOrUpdate);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited. This route handler performs [authorization](2), but is not rate-limited. This route handler performs [authorization](3), but is not rate-limited.
router.patch("/approve", authenticate, authorizeRoles([SUPERUSER]), validateUser, taskRequests.updateTaskRequests);

module.exports = router;