Skip to content

Removes dev flag from fetch task requests#1807

Merged
iamitprakash merged 3 commits intodevelopfrom
remove/task-requests-dev-flag
Jan 1, 2024
Merged

Removes dev flag from fetch task requests#1807
iamitprakash merged 3 commits intodevelopfrom
remove/task-requests-dev-flag

Conversation

@Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Dec 22, 2023

Date: 22 December 2023

Developer Name: @Ajeyakrishna-k


Description

Removes dev flag from fetch task requests api calls

Documentation Updated?

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Tested in Staging?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

router.post("/migrations", authenticate, authorizeRoles([SUPERUSER]), taskRequests.migrateTaskRequests);

// Deprecated | @Ajeyakrishna-k | https://github.com/Real-Dev-Squad/website-backend/issues/1597
router.post("/addOrUpdate", authenticate, validateUser, taskRequests.addOrUpdate);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited. This route handler performs [authorization](2), but is not rate-limited. This route handler performs [authorization](3), but is not rate-limited.
Copy link
Contributor

@ajoykumardas12 ajoykumardas12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update tested in staging and under feature flag descriptions.

@iamitprakash iamitprakash merged commit 77ca740 into develop Jan 1, 2024
@iamitprakash iamitprakash deleted the remove/task-requests-dev-flag branch January 1, 2024 17:37
@Ajeyakrishna-k Ajeyakrishna-k mentioned this pull request Jan 5, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants