Allow team members to add other members' todos to their watchlist#173
Allow team members to add other members' todos to their watchlist#173shobhan-sundar-goutam wants to merge 3 commits intodevelopfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughThe rendering logic for the "Actions" column in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TodoListTableRow
participant WatchListButton
User->>TodoListTableRow: View team todo list
TodoListTableRow->>WatchListButton: Render with todoId and watchlist status
WatchListButton-->>User: Display add/remove from watchlist button
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this chicken.
\\
(o>
<_ )
^^Files scanned
| File Path | Reviewed |
|---|---|
| modules/teams/team-tasks.tsx | ✅ |
| components/todo-list-table.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
|
@shobhan-sundar-goutam please check for one more case, where all three action buttons (ReassignButton, EditButton, WatchlistButton) are visible, UI shouldn't break |
Is this even possible to have three action buttons all at once? Can you please tell how you're asking check for three action buttons at once. I'm confused. Please point out if I'm missing anything |
| const { user } = useAuth() | ||
| const isRessignTodoCtaVisible = | ||
| const isReassignTodoCtaVisible = | ||
| todo.assignee?.user_type === USER_TYPE_ENUM.TEAM && team?.poc_id === user.id |
There was a problem hiding this comment.
Fixed the typo here. Although this is out of the scope of my task. Still fixed it to maintain clean code
Sorry i thought as a POC and assignee of task you can view Reassign Button |
|
@shobhan-sundar-goutam Please fix merge conflicts, rest looks good! |
|
Date: 08-08-2025
Developer Name: Shobhan Sundar Goutam (@shobhan-sundar-goutam)
Issue Ticket Number
Closes #150
Description
This PR adds support for allowing members of a team to add other members' todos to their watchlist.
The add/remove from watchlist button is now visible on the team todo list page for all relevant todos.
Additionally user will be able to add other todos in their dashboard to their watchlist
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screen.Recording.2025-08-08.at.12.04.30.AM.mov
Test Coverage
Screenshot 1
Additional Notes
Description by Korbit AI
What change is being made?
Refactor the todo list table component and team tasks module to allow team members to add other members' todos to their watchlist.
Why are these changes being made?
These changes streamline the user interface by ensuring the
WatchListButtonis consistently available, enabling team members to monitor tasks efficiently. The refactoring accommodates the feature request to empower collaborative task tracking and improves overall code maintainability by simplifying component conditionals.