feat: use TodoListTable and fix update logic in edit todo button#131
Merged
feat: use TodoListTable and fix update logic in edit todo button#131
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Summary by CodeRabbit
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EditTaskButton
participant UpdateTaskMutation
participant AssignMutation
participant Toast
participant QueryCache
User->>EditTaskButton: Submit edit
EditTaskButton->>UpdateTaskMutation: mutateAsync(updateTask)
UpdateTaskMutation-->>EditTaskButton: success/failure
alt Update success
EditTaskButton->>AssignMutation: mutateAsync(assign if needed)
AssignMutation-->>EditTaskButton: success/failure
alt All mutations succeed
EditTaskButton->>Toast: show success
EditTaskButton->>QueryCache: invalidate task query
EditTaskButton->>User: close edit form
else Any mutation fails
EditTaskButton->>Toast: show error
end
else Update fails
EditTaskButton->>Toast: show error
end
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yesyash
changed the title
yesyash
changed the title
Achintya-Chatterjee
previously approved these changes
Jul 18, 2025
AnujChhikara
previously approved these changes
Jul 18, 2025
yesyash
dismissed stale reviews from AnujChhikara and Achintya-Chatterjee
via
cf9253b
Achintya-Chatterjee
previously approved these changes
Jul 18, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
components/create-edit-todo-form.tsx(2 hunks)components/edit-task-button.tsx(1 hunks)modules/dashboard/components/dashboard-tabs.tsx(2 hunks)modules/dashboard/components/dashboard-watchlist-table.tsx(1 hunks)modules/dashboard/components/dashboard-watchlist-tasks-table.tsx(0 hunks)
💤 Files with no reviewable changes (1)
- modules/dashboard/components/dashboard-watchlist-tasks-table.tsx
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: Hariom01010
PR: Real-Dev-Squad/todo-frontend#51
File: __mocks__/types.ts:33-34
Timestamp: 2025-07-09T08:59:13.002Z
Learning: In the todo-frontend project, the PATCH task API endpoint payload uses `dueAt` and `startedAt` field names, but these update the `dueDate` and `startDate` fields respectively in the Task object. This is intentional according to the API contract design.
modules/dashboard/components/dashboard-tabs.tsx (1)
Learnt from: yesyash
PR: Real-Dev-Squad/todo-frontend#109
File: app/(internal-routes)/teams/[teamId]/layout.tsx:8-15
Timestamp: 2025-07-16T13:18:36.847Z
Learning: In Next.js layout components, error handling and validation for params extraction (like `const { teamId } = await params`) is not required in this codebase. The framework handles routing validation adequately.
components/create-edit-todo-form.tsx (1)
Learnt from: Hariom01010
PR: Real-Dev-Squad/todo-frontend#51
File: __mocks__/types.ts:33-34
Timestamp: 2025-07-09T08:59:13.002Z
Learning: In the todo-frontend project, the PATCH task API endpoint payload uses `dueAt` and `startedAt` field names, but these update the `dueDate` and `startDate` fields respectively in the Task object. This is intentional according to the API contract design.
components/edit-task-button.tsx (1)
Learnt from: Hariom01010
PR: Real-Dev-Squad/todo-frontend#51
File: __mocks__/types.ts:33-34
Timestamp: 2025-07-09T08:59:13.002Z
Learning: In the todo-frontend project, the PATCH task API endpoint payload uses `dueAt` and `startedAt` field names, but these update the `dueDate` and `startDate` fields respectively in the Task object. This is intentional according to the API contract design.
🧬 Code Graph Analysis (1)
modules/dashboard/components/dashboard-tabs.tsx (1)
modules/dashboard/components/dashboard-watchlist-table.tsx (1)
DashboardWatchlistTable(7-26)
🔇 Additional comments (5)
modules/dashboard/components/dashboard-tabs.tsx (2)
9-10: Import + usage update looks goodThe swap from
DashboardWatchlistTasksTabletoDashboardWatchlistTableis consistent and compiles cleanly. 👍
48-50: LGTM on component replacementRendering the new
<DashboardWatchlistTable />inside the WatchList tab matches the updated import. No further changes required.components/create-edit-todo-form.tsx (2)
127-128: LGTM!Good addition of
assigneeIdanduserTypeto the form's default values. This ensures proper initialization and aligns with the form schema definition.
286-286: Prop reordering looks good.The
isDisabledprop reordering maintains the same functionality.components/edit-task-button.tsx (1)
23-27: Clean mutation setup!Good simplification by removing inline handlers and using
mutateAsyncfor better control flow.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Generic Error Handling Without Context ▹ view | |
 |
Data transformation logic mixed with component ▹ view | |
 |
Unsafe null handling in tasks mapping ▹ view | |
 |
Magic Number in Priority Fallback ▹ view | ✅ Fix detected |
 |
Delayed Query Invalidation ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| modules/dashboard/components/dashboard-watchlist-table.tsx | ✅ |
| modules/dashboard/components/dashboard-tabs.tsx | ✅ |
| components/edit-task-button.tsx | ✅ |
| components/create-edit-todo-form.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
This was referenced Jul 19, 2025
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 19 july 2025
Developer Name: yash raj
Issue Ticket Number
Description
TodoListTablein the dashboard watchlist tab.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Description by Korbit AI
What change is being made?
Refactor task creating and editing logic by introducing
CrateTaskReqDto, utilizingTodoListTablefor the dashboard watchlist, refining error handling in form submissions, and modifying the task update logic to handle user assignments.Why are these changes being made?
These changes ensure better type handling with
CrateTaskReqDto, enhance the user interface with a unified table component (TodoListTable), and improve the robustness of form submissions with error message displays. The refined logic in task updates ensures seamless user assignments, making the code more understandable and reducing the potential for runtime errors.