[Onboarding Flow] Create onboarding flow card #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan09-raj
reviewed
Sep 4, 2023
| border: 2px solid var(--color-lightgrey); | ||
| background-color: var(--color-cultured); | ||
| border-radius: 10px; | ||
| background-color: #FFF; |
There was a problem hiding this comment.
Can we please use color vars ?
rohan09-raj
reviewed
Sep 4, 2023
| min-height: 30vh; | ||
| min-width: 75vw; | ||
| padding: 56px 16px; | ||
| margin-top: -5rem; |
There was a problem hiding this comment.
Can we avoid negative margins ?
rohan09-raj
reviewed
Sep 4, 2023
There was a problem hiding this comment.
This is already present I think, please use .png or .svg for any image resources or .webp is also good
rohan09-raj
changed the title
Merged
2 tasks
|
This is already done in #607 That's why closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Closes #580
What is the change?
Is Development Tested?
After Change Video
cqUVRaaN6T.mp4