Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding Flow]- Created two input fields, 'firstname' and 'lastname' in signup Details page #607

Merged
merged 40 commits into from
Sep 4, 2023
Merged

[Onboarding Flow]- Created two input fields, 'firstname' and 'lastname' in signup Details page #607

merged 40 commits into from
Sep 4, 2023

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Aug 28, 2023 •
edited
Loading

Issue

Closes #580

Parent Ticket: Real-Dev-Squad/todo-action-items#178

What is the change?

  • Done the initial setup to handle stepper of signup
  • Created two file: stepper-signup.js and stepper-signup.hbs
  • Create two nested file: signup-step/step-one.hbs and signup-step/step-one.js
  • Create one nested file: signup-step/step-zero.hbs
  • Added card and logo(different step have different logo) on new onboarding flow
  • Created two new input fields, 'firstname' and 'lastname', in the child component. These input fields allow users to enter their first name and last name.
  • Added feature flag

Is Development Tested?

  • Yes
  • No

After Change Video

Feature UI and feature under feature flag

5s6WYlxFFB.mp4

Testing video

FtOX464SKt.mp4

Test ensures that the SignupSteps::StepOne/ component correctly interacts with the parent component by simulating input changes and verifying that the parent's handleInputChange function updates the signupDetails object

Code_vivOScU4Rq.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 28, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: db11dc8
Status: ✅  Deploy successful!
Preview URL: https://fd3a1f8b.www-rds.pages.dev
Branch Preview URL: https://feature-onboarding-flow-1.www-rds.pages.dev

View logs

@shubhamsinghbundela shubhamsinghbundela changed the title feat: Set up StepperSignupComponent with initial step handling [Onboarding Flow]- Implement Signup Details Page Of User Aug 28, 2023
@shubhamsinghbundela shubhamsinghbundela self-assigned this Aug 28, 2023
@shubhamsinghbundela shubhamsinghbundela added UI OnboardingFlow enhancement Enhances an existing feature ember-migration and removed enhancement Enhances an existing feature UI labels Aug 28, 2023
@shubhamsinghbundela shubhamsinghbundela marked this pull request as draft August 28, 2023 14:45
DeRaowl
DeRaowl previously requested changes Aug 31, 2023
View reviewed changes
app/components/stepper-signup.hbs Outdated Show resolved Hide resolved
app/components/stepper-signup.js Outdated Show resolved Hide resolved
app/templates/join.hbs Show resolved Hide resolved
tests/integration/components/stepper-signup-test.js Outdated Show resolved Hide resolved
@shubhamsinghbundela shubhamsinghbundela changed the title [Onboarding Flow]- Implement Signup Details Page Of User [Onboarding Flow]- Created two input fields, 'firstname' and 'lastname' in signup Details page Sep 1, 2023
satyam73
satyam73 requested changes Sep 1, 2023
View reviewed changes
app/components/stepper-signup.hbs Outdated Show resolved Hide resolved
tests/integration/components/signup-steps/step-one-test.js Outdated Show resolved Hide resolved
tests/integration/components/signup-steps/step-one-test.js Outdated Show resolved Hide resolved
tests/integration/components/signup-steps/step-one-test.js Outdated Show resolved Hide resolved
tests/integration/components/stepper-signup-test.js Outdated Show resolved Hide resolved
tests/integration/components/stepper-signup-test.js Outdated Show resolved Hide resolved
@satyam73
Copy link
Member

satyam73 commented Sep 1, 2023

@shubhamsigdar1 if the PR is ready mark it as Ready for review

satyam73
satyam73 previously approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vinit717
vinit717 reviewed Sep 4, 2023
View reviewed changes
public/assets/icons/link-logo.png Outdated Show resolved Hide resolved
tests/integration/components/signup-steps/step-one-test.js Outdated Show resolved Hide resolved
app/styles/stepper.module.css Outdated Show resolved Hide resolved
vinit717
vinit717 previously approved these changes Sep 4, 2023
View reviewed changes
vinit717
vinit717 previously approved these changes Sep 4, 2023
View reviewed changes
satyam73
satyam73 previously approved these changes Sep 4, 2023
View reviewed changes
@rohan09-raj rohan09-raj mentioned this pull request Sep 4, 2023
Closed
2 tasks
@rohan09-raj rohan09-raj dismissed DeRaowl’s stale review September 4, 2023 19:08

Changes are addressed

@rohan09-raj rohan09-raj merged commit 254640c into develop-ember Sep 4, 2023
@rohan09-raj rohan09-raj deleted the feature/onboarding-flow-1 branch September 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurvkhare apurvkhare apurvkhare left review comments

@sumitd94 sumitd94 sumitd94 approved these changes

@rohan09-raj rohan09-raj rohan09-raj approved these changes

@satyam73 satyam73 satyam73 left review comments

@vinit717 vinit717 vinit717 left review comments

@DeRaowl DeRaowl Awaiting requested review from DeRaowl

Assignees

@shubhamsinghbundela shubhamsinghbundela

Labels
ember-migration OnboardingFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shubhamsinghbundela @satyam73 @apurvkhare @DeRaowl @sumitd94 @rohan09-raj @vinit717