Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forkJoin): accept promise, resultselector as parameter of forkJoin #671

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 7, 2015

closes #507

forkJoin now accepts promises as well as result selector, and expanded test coverage.

@kwonoj kwonoj force-pushed the feat-forkjoin branch 2 times, most recently from 1900a6f to c8a1425 Compare November 10, 2015 19:48
@kwonoj
Copy link
Member Author

kwonoj commented Nov 10, 2015

Updated PR. Appreciate take time to review with suggestions, @Blesh

@benlesh
Copy link
Member

benlesh commented Nov 10, 2015

Looks really good. I found the most minor thing in the world (a let instead of a const). You don't have to fix it if you don't want to, we can just merge the changes. Just thought I'd point it out.

@kwonoj
Copy link
Member Author

kwonoj commented Nov 10, 2015

You don't have to fix it if you don't want to

I've update it, though I usually try to be strict on code in this case I obviously missed it. Thanks for pointing it out.

@benlesh
Copy link
Member

benlesh commented Nov 10, 2015

I've update it, though I usually try to be strict on code in this case I obviously missed it. Thanks for pointing it out.

No problem, what I try to do is const everything and then let the compiler or IDE complain at me when I need a let

@benlesh
Copy link
Member

benlesh commented Nov 10, 2015

Merged with 190f349 ... thanks! Good work!

@benlesh benlesh closed this Nov 10, 2015
@kwonoj kwonoj deleted the feat-forkjoin branch November 10, 2015 21:40
Promise<any> |
((...values: Array<any>) => any)>) {
super();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind nitpicking, but I noticed 3 spaces for indentation here. Should be 2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind it at all, actually I also do similar thing when I review with my colleagues :) I'll check codes and apply changes if necessary.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accepting promise for forkJoin()?
3 participants