-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accepting promise for forkJoin()? #507
Comments
Debatable. As long as it doesn't affect performance, I'm okay with it. |
|
I'll try to add to accept |
@kwonoj I don't recall.. did this get done? |
It's WIP in my stash, but haven't completed yet while creating other PRs. I'll complete and create PR. |
No hurry. Just checking |
RxJS4's
forkJoin
accepts promise as well as observablesargs (Arguments | Array): An array or arguments of Observable sequences or Promises to collect the last elements for.
while current implementation does not. Is this intended design to drop promise? If promise can be accepted, PR #506 might need to be updated to include it as well as updating implementation.
The text was updated successfully, but these errors were encountered: