refactor: More elegantly handle super gross mode#6478
Merged
benlesh merged 2 commits intoReactiveX:masterfrom Jun 17, 2021
Merged
refactor: More elegantly handle super gross mode#6478benlesh merged 2 commits intoReactiveX:masterfrom
benlesh merged 2 commits intoReactiveX:masterfrom
Conversation
Member
Author
cartant
approved these changes
Jun 17, 2021
Collaborator
cartant
left a comment
cartant
left a comment
There was a problem hiding this comment.
LGTM. Nice. Gross, but nice.
Member
Author
|
Yeah, I can't wait to remove all of this junk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative to #6472 ... which is SHENANIGANS
this adds a cleaner solution for handling super-gross mode. It shouldn't have much impact on regular use.