fix(useDeprecatedSynchronousErrorHandling): now throws properly when notifying a Subject#6472
fix(useDeprecatedSynchronousErrorHandling): now throws properly when notifying a Subject#6472benlesh wants to merge 1 commit intoReactiveX:masterfrom
Conversation
|
cc @leggechr |
src/internal/Subscriber.ts
Outdated
| */ | ||
| error(err?: any): void { | ||
| if (this.isStopped) { | ||
| if (this.isStopped && !config.useDeprecatedSynchronousErrorHandling) { |
There was a problem hiding this comment.
Surely this is going to cause other problems? This renders stopped meaningless for error notifications if that config is used? How did this ever work in v6? If it didn't, should we really change this? FWIW, I don't particularly care - the sooner this configuration setting is removed, the better, IMO - but I thought I'd point it out.
|
|
||
| export declare const observable: string | symbol; | ||
| export declare const observable: string | typeof Symbol.observable; | ||
|
|
There was a problem hiding this comment.
Why has this changed? The last time this happened, IIRC, it was in that PR that sought to bump to TS 4.3. Are you sure you have 4.2 installed?
src/internal/Subscriber.ts
Outdated
| */ | ||
| error(err?: any): void { | ||
| if (this.isStopped) { | ||
| if (this.isStopped && !config.useDeprecatedSynchronousErrorHandling) { |
There was a problem hiding this comment.
Surely this is going to cause other problems? This renders stopped meaningless for error notifications if that config is used? How did this ever work in v6? If it didn't, should we really change this? FWIW, I don't particularly care - the sooner this configuration setting is removed, the better, IMO - but I thought I'd point it out.
cartant
left a comment
cartant
left a comment
There was a problem hiding this comment.
Actually, the api_guardian thing needs to be addressed.
|
This caused tons more failing tests in google. The error is: |
benlesh
force-pushed
the
fix/6471-super-gross-subject-next
branch
from
69aea0b to
bb1b637
Compare
|
Closing in favor of #6478 |
3 participants
Resolves #6471