Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - SponsorBlock): Improve create segment manual seek accuracy #3491

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Jul 31, 2024

Fixes the incorrect seeking when using the fine seeking function the first time. This is done by hooking an existing relative seek function.

Also removes the use of reflections for the seek functions.

Also tested while casting and it works as expected.

Integration changes

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 1544981 into ReVanced:dev Aug 2, 2024
2 checks passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/sponsorblock_find_adjustment branch August 2, 2024 13:40
revanced-bot pushed a commit that referenced this pull request Aug 2, 2024
# [4.12.0-dev.15](v4.12.0-dev.14...v4.12.0-dev.15) (2024-08-02)

### Bug Fixes

* **YouTube - SponsorBlock:** Improve create segment manual seek accuracy ([#3491](#3491)) ([1544981](1544981))
revanced-bot pushed a commit that referenced this pull request Aug 6, 2024
# [4.12.0](v4.11.0...v4.12.0) (2024-08-06)

### Bug Fixes

* **Google Photos - GmsCore support:** Fix by checking first if a method exists before trying to patch it ([acf38ca](acf38ca))
* **Instagram - Hide ads:**  Restore compatibility with latest version by fixing fingerprint ([#3455](#3455)) ([4505fa4](4505fa4))
* **Messenger - Disable switching emoji to sticker:** Constrain to last working version `439.0.0.29.119` ([6207c31](6207c31))
* **SoundCloud - Enable offline sync:** Stop crashing by reversing order of patching instructions from last to first to retain indices ([63b6ced](63b6ced))
* **YouTube - Bypass image region restrictions:** Move setting to `Misc` menu ([094ae59](094ae59))
* **YouTube - Client Spoof:** Restore missing high qualities by spoofing the iOS client user agent ([#3468](#3468)) ([0e6ae5f](0e6ae5f))
* **YouTube - Hide keyword content:** Do not hide flyout menu ([687c9f7](687c9f7))
* **YouTube - SponsorBlock:** Correctly show minute timestamp when creating a new segment ([d74c366](d74c366))
* **YouTube - SponsorBlock:** Improve create segment manual seek accuracy ([#3491](#3491)) ([1544981](1544981))
* **YouTube - Spoof client:** Fix tracking history on brand accounts ([#3480](#3480)) ([69c1f16](69c1f16))
* **YouTube - Spoof client:** Restore livestream audio only playback with iOS spoofing ([#3504](#3504)) ([90d3288](90d3288))

### Features

* Add `Hide mock location` patch ([#3417](#3417)) ([5f81b40](5f81b40))
* Add `Spoof build info` patch ([e7829b4](e7829b4))
* **Boost for Reddit:** Add `Disable ads` patch ([#3474](#3474)) ([b292c20](b292c20))
* **CandyLink:** Remove non-functional `Unlock pro` patch ([7ae9f8f](7ae9f8f))
* **Expense Manager:** Remove non-functional `Unlock pro` patch ([ebbcac7](ebbcac7))
* **Google News:** Add `Enable CustomTabs` and `GmsCore support` patch ([#3111](#3111)) ([ad59096](ad59096))
* **Google Photos:** Add `GmsCore support` patch ([#3414](#3414)) ([24528e0](24528e0))
* **Instagram:** Remove unnecessary `Hide timeline ads` patch ([5e1d001](5e1d001))
* **SoundCloud:** Add `Enable offline sync` patch ([#3407](#3407)) ([4de86c6](4de86c6))
* **SwissID:** Add `Remove Google Play Integrity Integrity check` patch ([#3478](#3478)) ([60492ae](60492ae))
* **YouTube - Description components:** Add `Hide 'Key concepts' section` option ([#3495](#3495)) ([d75b645](d75b645))
* **YouTube:** Add `Bypass image region restrictions` patch ([#3442](#3442)) ([765fab2](765fab2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(YouTube - SponsorBlock): First press on the time adjustment buttons jumps back too far
2 participants