Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(YouTube - Spoof client): Unlock more qualities by spoofing the iOS client user agent #3468

Merged
merged 5 commits into from
Jul 28, 2024
Merged

fix(YouTube - Spoof client): Unlock more qualities by spoofing the iOS client user agent #3468

merged 5 commits into from
Jul 28, 2024

Conversation

zainarbani
Copy link
Contributor

@zainarbani zainarbani commented Jul 24, 2024 •
edited
Loading

@zainarbani zainarbani mentioned this pull request Jul 24, 2024
Merged
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Client Spoof): Set user-agent for IOS client" fix(YouTube - Client Spoof): Set user-agent Jul 24, 2024
@oSumAtrIX oSumAtrIX changed the title fix(YouTube - Client Spoof): Set user-agent fix(YouTube - Client Spoof): Unlock more qualities by spoofing the iOS client user agent Jul 24, 2024
@oSumAtrIX oSumAtrIX self-requested a review July 24, 2024 19:00
@LisoUseInAIKyrios
Copy link
Contributor

If this fixes higher resolutions for all users/devices, the spoof summary disclaimer can be updated to remove the limitation.

@zainarbani
Copy link
Contributor Author

If this fixes higher resolutions for all users/devices, the spoof summary disclaimer can be updated to remove the limitation.

I don't have another devices to test the patch, should i push the limitation update?

@oSumAtrIX
Copy link
Member

I'd say before we remove the warning and add it back, we can keep it, and remove it once we confirm it works fine

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Jul 27, 2024 that may be closed by this pull request
bug(YouTube): Spoof client patch - various side effects (watch history, auto resume playback, ...) #3208
Closed
15 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios mentioned this pull request Jul 27, 2024
Closed
15 tasks
@0xrxL
Copy link

0xrxL commented Jul 27, 2024

Background playback for livestream is still bugged, despite this change. What a sin.

oSumAtrIX
oSumAtrIX approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed some refactoring changes. Please review if the patch still works as expected. Apart from that lgtm.

@oSumAtrIX
Merge branch 'refs/heads/dev' into fix/ios-user-agent
1e136ab 
# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/misc/fix/playback/SpoofClientPatch.kt
#	src/main/resources/addresources/values/strings.xml
@oSumAtrIX oSumAtrIX merged commit 0e6ae5f into ReVanced:dev Jul 28, 2024
2 checks passed
@welcome Welcome
Copy link

welcome bot commented Jul 28, 2024

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

revanced-bot pushed a commit that referenced this pull request Jul 28, 2024
@semantic-release-bot
chore(release): 4.12.0-dev.10 [skip ci]
328ce03 
# [4.12.0-dev.10](v4.12.0-dev.9...v4.12.0-dev.10) (2024-07-28)

### Bug Fixes

* **YouTube - Client Spoof:** Restore missing high qualities by spoofing the iOS client user agent ([#3468](#3468)) ([0e6ae5f](0e6ae5f))
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Client Spoof): Unlock more qualities by spoofing the iOS client user agent fix(YouTube - Spoof client): Unlock more qualities by spoofing the iOS client user agent Jul 28, 2024
revanced-bot pushed a commit that referenced this pull request Aug 6, 2024
@semantic-release-bot
chore(release): 4.12.0 [skip ci]
2571d6f 
# [4.12.0](v4.11.0...v4.12.0) (2024-08-06)

### Bug Fixes

* **Google Photos - GmsCore support:** Fix by checking first if a method exists before trying to patch it ([acf38ca](acf38ca))
* **Instagram - Hide ads:**  Restore compatibility with latest version by fixing fingerprint ([#3455](#3455)) ([4505fa4](4505fa4))
* **Messenger - Disable switching emoji to sticker:** Constrain to last working version `439.0.0.29.119` ([6207c31](6207c31))
* **SoundCloud - Enable offline sync:** Stop crashing by reversing order of patching instructions from last to first to retain indices ([63b6ced](63b6ced))
* **YouTube - Bypass image region restrictions:** Move setting to `Misc` menu ([094ae59](094ae59))
* **YouTube - Client Spoof:** Restore missing high qualities by spoofing the iOS client user agent ([#3468](#3468)) ([0e6ae5f](0e6ae5f))
* **YouTube - Hide keyword content:** Do not hide flyout menu ([687c9f7](687c9f7))
* **YouTube - SponsorBlock:** Correctly show minute timestamp when creating a new segment ([d74c366](d74c366))
* **YouTube - SponsorBlock:** Improve create segment manual seek accuracy ([#3491](#3491)) ([1544981](1544981))
* **YouTube - Spoof client:** Fix tracking history on brand accounts ([#3480](#3480)) ([69c1f16](69c1f16))
* **YouTube - Spoof client:** Restore livestream audio only playback with iOS spoofing ([#3504](#3504)) ([90d3288](90d3288))

### Features

* Add `Hide mock location` patch ([#3417](#3417)) ([5f81b40](5f81b40))
* Add `Spoof build info` patch ([e7829b4](e7829b4))
* **Boost for Reddit:** Add `Disable ads` patch ([#3474](#3474)) ([b292c20](b292c20))
* **CandyLink:** Remove non-functional `Unlock pro` patch ([7ae9f8f](7ae9f8f))
* **Expense Manager:** Remove non-functional `Unlock pro` patch ([ebbcac7](ebbcac7))
* **Google News:** Add `Enable CustomTabs` and `GmsCore support` patch ([#3111](#3111)) ([ad59096](ad59096))
* **Google Photos:** Add `GmsCore support` patch ([#3414](#3414)) ([24528e0](24528e0))
* **Instagram:** Remove unnecessary `Hide timeline ads` patch ([5e1d001](5e1d001))
* **SoundCloud:** Add `Enable offline sync` patch ([#3407](#3407)) ([4de86c6](4de86c6))
* **SwissID:** Add `Remove Google Play Integrity Integrity check` patch ([#3478](#3478)) ([60492ae](60492ae))
* **YouTube - Description components:** Add `Hide 'Key concepts' section` option ([#3495](#3495)) ([d75b645](d75b645))
* **YouTube:** Add `Bypass image region restrictions` patch ([#3442](#3442)) ([765fab2](765fab2))
@0xrxL 0xrxL mentioned this pull request Aug 6, 2024
Closed
3 tasks
@zainarbani zainarbani deleted the fix/ios-user-agent branch August 18, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(YouTube): Spoof client patch - various side effects (watch history, auto resume playback, ...)
4 participants
@zainarbani @LisoUseInAIKyrios @oSumAtrIX @0xrxL