fix: 8945 (#8945) #9393
Merged
fix: 8945 (#8945) #9393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced deprecated wrapper methods in last file.
RoboErikG
merged commit 4353f90
into
RaspberryPiFoundation:develop
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced deprecated wrapper methods in last file.
The basics
The details
Resolves
Fixes issue #8945
Proposed Changes
Update event_test to stop using deprecated methods.
Reason for Changes
PR #8401 deprecated certain …ById methods on VariableMap, and PR #8415 subsequently deprecated related wrapper methods on Workspace, with PR #8946 completing the refactor by removing the overriding versions of those methods on WorkspaceSvg as well as replacing a number of the remaining calls to those methods from code in core/.
Test should be updated to use non-deprecated methods
Test Coverage
Tests were updated to reflect method deprecation.
Documentation
Additional Information