refactor: deprecate and clean up variable-related methods. #8415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jul 22, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Sorry for the late review :/
BeksOmega
approved these changes
Jul 22, 2024
This was referenced Apr 30, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8083
Proposed Changes
This PR deprecates the variable-related methods in
Workspacethat simply pass through calls to theVariableMap. Callers should retrieve the VariableMap from the workspace and call the corresponding methods on it.Several internal methods that are not in the variable interfaces, have been moved to the Variables namespace, or are unnecessary have been deleted.