fix: context menus on flyout #9116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboErikG
approved these changes
May 30, 2025
Contributor
Author
|
Gonna merge this to unblock the release, but @BenHenning if you could retroactively review this when you're back, I'd feel better about it |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9111
Proposed Changes
Don't close the flyout if the flyout is losing focus due to ephemeral focus
Reason for Changes
Context menus are ephemeral focus
Test Coverage
This passes all existing tests and manual inspection. I'll probably add one for it in kbe, but I'll have someone else manually play with this too to make sure I haven't broken a different case I'm not testing for.
Documentation
Additional Information