Creating a variable closes the flyout

[microbit-robert]

Check for duplicates

• I have searched for similar issues before opening a new one.

Description

Creating a variable via mouse or keyboard causes the flyout to close. This seems to be related to this change. This may need a similar fix to #9116, however, it might be hard to know what to focus as the dialogs can be customised. Multiple dialogs can also appear in succession (e.g., when trying to create a variable that already exists).

Note: for some reason, if you have dev tools open, the flyout stays open.

Reproduction steps

Stack trace

Screenshots

No response

Browsers

No response

[BenHenning]

I think this is the same as #9106 but that one is a bit hard to find so I'm not surprised it wasn't discovered when searching (I actually had a bit of difficulty finding it to post this).

[BenHenning]

Following up: it seems that the directionality is actually reversed from what I expected.

#9106 is tracking the flyout auto closing when creating variables with a keyboard because, at that time, it was fixed for mouse users (see #8982). It has since broken. :( I'm not sure if this broke before we launched v12, or if it's been in a subsequent release. Either way, I can also confirm that the broken behavior of the flyout auto-closing happens for both mouse and keyboard use cases again.

I haven't verified that this broke in #9079, but it's certainly possible. That likely means there are actually two levels of problems here: the regression that re-broke the flow for mouse users, and the underlying problem for keyboard navigation.

[BenHenning]

#9176 solves the issue, though it's not done yet because there's still the issue of the flyout really wanting to auto-close. It fixes the main issues of the window prompt permanently losing focus and flyout recreation permanently losing focus. I will have to think a lot more on how to solve the auto-closing issue sometime next week.