Skip to content

fix!: delete marker move event and tests #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachel-fenichel merged 1 commit into from
May 8, 2025
Merged

fix!: delete marker move event and tests #9013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/events/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export {CommentDelete} from './events_comment_delete.js';
export {CommentDrag, CommentDragJson} from './events_comment_drag.js';
export {CommentMove, CommentMoveJson} from './events_comment_move.js';
export {CommentResize, CommentResizeJson} from './events_comment_resize.js';
export {MarkerMove, MarkerMoveJson} from './events_marker_move.js';
export {Selected, SelectedJson} from './events_selected.js';
export {ThemeChange, ThemeChangeJson} from './events_theme_change.js';
export {
Expand Down Expand Up @@ -77,7 +76,6 @@ export const CREATE = EventType.BLOCK_CREATE;
/** @deprecated Use BLOCK_DELETE instead */
export const DELETE = EventType.BLOCK_DELETE;
export const FINISHED_LOADING = EventType.FINISHED_LOADING;
export const MARKER_MOVE = EventType.MARKER_MOVE;
/** @deprecated Use BLOCK_MOVE instead */
export const MOVE = EventType.BLOCK_MOVE;
export const SELECTED = EventType.SELECTED;
Expand Down
133 changes: 0 additions & 133 deletions core/events/events_marker_move.ts
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions core/events/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import type {CommentDelete} from './events_comment_delete.js';
import type {CommentDrag} from './events_comment_drag.js';
import type {CommentMove} from './events_comment_move.js';
import type {CommentResize} from './events_comment_resize.js';
import type {MarkerMove} from './events_marker_move.js';
import type {Selected} from './events_selected.js';
import type {ThemeChange} from './events_theme_change.js';
import type {ToolboxItemSelect} from './events_toolbox_item_select.js';
Expand Down Expand Up @@ -99,11 +98,6 @@ export function isClick(event: Abstract): event is Click {
return event.type === EventType.CLICK;
}

/** @returns true iff event.type is EventType.MARKER_MOVE */
export function isMarkerMove(event: Abstract): event is MarkerMove {
return event.type === EventType.MARKER_MOVE;
}

/** @returns true iff event.type is EventType.BUBBLE_OPEN */
export function isBubbleOpen(event: Abstract): event is BubbleOpen {
return event.type === EventType.BUBBLE_OPEN;
Expand Down
44 changes: 0 additions & 44 deletions tests/mocha/event_marker_move_test.js
View file
Open in desktop

This file was deleted.

80 changes: 0 additions & 80 deletions tests/mocha/event_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import * as Blockly from '../../build/src/core/blockly.js';
import * as eventUtils from '../../build/src/core/events/utils.js';
import {ASTNode} from '../../build/src/core/keyboard_nav/ast_node.js';
import {assert} from '../../node_modules/chai/chai.js';
import {
assertEventEquals,
Expand Down Expand Up @@ -519,85 +518,6 @@ suite('Events', function () {
newValue: 'new value',
}),
},
{
title: 'null to Block Marker move',
class: Blockly.Events.MarkerMove,
getArgs: (thisObj) => [
thisObj.block,
true,
null,
new ASTNode(ASTNode.types.BLOCK, thisObj.block),
],
getExpectedJson: (thisObj) => ({
type: 'marker_move',
group: '',
isCursor: true,
blockId: thisObj.block.id,
oldNode: undefined,
newNode: new ASTNode(ASTNode.types.BLOCK, thisObj.block),
}),
},
{
title: 'null to Workspace Marker move',
class: Blockly.Events.MarkerMove,
getArgs: (thisObj) => [
null,
true,
null,
ASTNode.createWorkspaceNode(
thisObj.workspace,
new Blockly.utils.Coordinate(0, 0),
),
],
getExpectedJson: (thisObj) => ({
type: 'marker_move',
group: '',
isCursor: true,
blockId: undefined,
oldNode: undefined,
newNode: ASTNode.createWorkspaceNode(
thisObj.workspace,
new Blockly.utils.Coordinate(0, 0),
),
}),
},
{
title: 'Workspace to Block Marker move',
class: Blockly.Events.MarkerMove,
getArgs: (thisObj) => [
thisObj.block,
true,
ASTNode.createWorkspaceNode(
thisObj.workspace,
new Blockly.utils.Coordinate(0, 0),
),
new ASTNode(ASTNode.types.BLOCK, thisObj.block),
],
getExpectedJson: (thisObj) => ({
type: 'marker_move',
group: '',
isCursor: true,
blockId: thisObj.block.id,
oldNode: ASTNode.createWorkspaceNode(
thisObj.workspace,
new Blockly.utils.Coordinate(0, 0),
),
newNode: new ASTNode(ASTNode.types.BLOCK, thisObj.block),
}),
},
{
title: 'Block to Workspace Marker move',
class: Blockly.Events.MarkerMove,
getArgs: (thisObj) => [
null,
true,
new ASTNode(ASTNode.types.BLOCK, thisObj.block),
ASTNode.createWorkspaceNode(
thisObj.workspace,
new Blockly.utils.Coordinate(0, 0),
),
],
},
{
title: 'Selected',
class: Blockly.Events.Selected,
Expand Down
1 change: 0 additions & 1 deletion tests/mocha/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@
import './event_comment_move_test.js';
import './event_comment_drag_test.js';
import './event_comment_resize_test.js';
import './event_marker_move_test.js';
import './event_selected_test.js';
import './event_theme_change_test.js';
import './event_toolbox_item_select_test.js';
Expand Down
Loading