fix!: delete marker move event and tests#9013
Merged
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from May 8, 2025
rachel-fenichel:events_marker_move
Merged
fix!: delete marker move event and tests#9013rachel-fenichel merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from rachel-fenichel:events_marker_move
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:rc/v12.0.0from
rachel-fenichel:events_marker_move
Conversation
github-actions
bot
added
breaking change
gonfunko
approved these changes
May 8, 2025
rachel-fenichel
merged commit b6b229e
into
RaspberryPiFoundation:rc/v12.0.0
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9009
Proposed Changes
Delete an event that fired when markers were moved, and delete all tests related to it.
This event was already not being fired anywhere besides tests.
Reason for Changes
Now that focus and selection are synced, there is no need for a separate marker move event. Interested parties can listen for selected events instead.
Test Coverage
Removed dead tests from core.
Documentation
breaking change: Deletes events with the type string
'marker_move'. No external code is expected to either create or listen to these events, and I have verified that it is not being used in keyboard-nav (old plugin) or keyboard-experimentation (new plugin).Additional Information
This is a step toward deleting vestigial ASTNode code after the switch to
INavigable.