refactor!: Remove old cursor and tab support. #8803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
added
breaking change
1 task
Collaborator
|
I filed #8821 because we do want to keep some tab behaviour. You can merge this and then re-add tab through the main cursor, or you can do them as separate pieces of work--both work for me. |
rachel-fenichel
approved these changes
Mar 27, 2025
gonfunko
merged commit 7a07b4b
into
RaspberryPiFoundation:rc/v12.0.0
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
BasicCursorandTabNavigateCursor#8795Proposed Changes
This PR removes the
BasicCursorandTabNavigateCursorclasses. These provided limited support for keyboard navigation, and have been supplanted by the much-improved experience in https://github.com/google/blockly-keyboard-experimentation. The latter cursor was also used by input fields and blocks to provide support for tabbing between input fields on a block. This was limited toFieldInputsubclasses, and has again been supplanted by the keyboard-experimentation plugin.Breaking Changes
BasicCursorandTabNavigateCursorhave been removedField.isTabNavigable()has been removedBlockSvg.tab()has been removedIn all cases, use of the keyboard-experimentation plugin is the recommended migration path.