refactor!: Remove old cursor and tab support. (#8803)

Author: gonfunko

core/block_svg.ts

@@ -34,7 +34,6 @@ import {BlockDragStrategy} from './dragging/block_drag_strategy.js';
 import type {BlockMove} from './events/events_block_move.js';
 import {EventType} from './events/type.js';
 import * as eventUtils from './events/utils.js';
-import type {Field} from './field.js';
 import {FieldLabel} from './field_label.js';
 import {IconType} from './icons/icon_types.js';
 import {MutatorIcon} from './icons/mutator_icon.js';
@@ -46,8 +45,6 @@ import type {ICopyable} from './interfaces/i_copyable.js';
 import type {IDragStrategy, IDraggable} from './interfaces/i_draggable.js';
 import {IIcon} from './interfaces/i_icon.js';
 import * as internalConstants from './internal_constants.js';
-import {ASTNode} from './keyboard_nav/ast_node.js';
-import {TabNavigateCursor} from './keyboard_nav/tab_navigate_cursor.js';
 import {MarkerManager} from './marker_manager.js';
 import {Msg} from './msg.js';
 import * as renderManagement from './render_management.js';
@@ -550,35 +547,6 @@ export class BlockSvg
     input.appendField(new FieldLabel(text), collapsedFieldName);
   }
 
-  /**
-   * Open the next (or previous) FieldTextInput.
-   *
-   * @param start Current field.
-   * @param forward If true go forward, otherwise backward.
-   */
-  tab(start: Field, forward: boolean) {
-    const tabCursor = new TabNavigateCursor();
-    tabCursor.setCurNode(ASTNode.createFieldNode(start)!);
-    const currentNode = tabCursor.getCurNode();
-
-    if (forward) {
-      tabCursor.next();
-    } else {
-      tabCursor.prev();
-    }
-
-    const nextNode = tabCursor.getCurNode();
-    if (nextNode && nextNode !== currentNode) {
-      const nextField = nextNode.getLocation() as Field;
-      nextField.showEditor();
-
-      // Also move the cursor if we're in keyboard nav mode.
-      if (this.workspace.keyboardAccessibilityMode) {
-        this.workspace.getCursor()!.setCurNode(nextNode);
-      }
-    }
-  }
-
   /**
    * Handle a pointerdown on an SVG block.
    *

core/blockly.ts

@@ -169,10 +169,8 @@ import {IVariableMap} from './interfaces/i_variable_map.js';
 import {IVariableModel, IVariableState} from './interfaces/i_variable_model.js';
 import * as internalConstants from './internal_constants.js';
 import {ASTNode} from './keyboard_nav/ast_node.js';
-import {BasicCursor} from './keyboard_nav/basic_cursor.js';
 import {Cursor} from './keyboard_nav/cursor.js';
 import {Marker} from './keyboard_nav/marker.js';
-import {TabNavigateCursor} from './keyboard_nav/tab_navigate_cursor.js';
 import type {LayerManager} from './layer_manager.js';
 import * as layers from './layers.js';
 import {MarkerManager} from './marker_manager.js';
@@ -432,7 +430,6 @@ Names.prototype.populateProcedures = function (
 // Re-export submodules that no longer declareLegacyNamespace.
 export {
   ASTNode,
-  BasicCursor,
   Block,
   BlockSvg,
   BlocklyOptions,
@@ -589,7 +586,6 @@ export {
   ScrollbarPair,
   SeparatorFlyoutInflater,
   ShortcutRegistry,
-  TabNavigateCursor,
   Theme,
   ThemeManager,
   Toolbox,

core/field.ts

@@ -1331,15 +1331,6 @@ export abstract class Field<T = any>
     return false;
   }
 
-  /**
-   * Returns whether or not the field is tab navigable.
-   *
-   * @returns True if the field is tab navigable.
-   */
-  isTabNavigable(): boolean {
-    return false;
-  }
-
   /**
    * Handles the given keyboard shortcut.
    *

core/field_input.ts

@@ -562,11 +562,6 @@ export abstract class FieldInput<T extends InputTypes> extends Field<
       );
       WidgetDiv.hideIfOwner(this);
       dropDownDiv.hideWithoutAnimation();
-    } else if (e.key === 'Tab') {
-      WidgetDiv.hideIfOwner(this);
-      dropDownDiv.hideWithoutAnimation();
-      (this.sourceBlock_ as BlockSvg).tab(this, !e.shiftKey);
-      e.preventDefault();
     }
   }
 
@@ -674,15 +669,6 @@ export abstract class FieldInput<T extends InputTypes> extends Field<
     return true;
   }
 
-  /**
-   * Returns whether or not the field is tab navigable.
-   *
-   * @returns True if the field is tab navigable.
-   */
-  override isTabNavigable(): boolean {
-    return true;
-  }
-
   /**
    * Use the `getText_` developer hook to override the field's text
    * representation. When we're currently editing, return the current HTML value